Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression builder: add splitters and change buttons #1073

Merged
merged 1 commit into from Jan 14, 2014

Conversation

Projects
None yet
5 participants
@3nids
Copy link
Member

3nids commented Jan 14, 2014

This adds two sliders to the dialog:

  • one vertical between function list and selected function help
  • one between the top and the expression part (to have more lines in case of long expressions)

Also, I rephrased the buttons "load values". OK for the buttons?

image

@3nids

This comment has been minimized.

Copy link
Member Author

3nids commented Jan 14, 2014

Thanks to @NathanW2 for your help!

@ghost ghost assigned NathanW2 Jan 14, 2014

@3nids

This comment has been minimized.

Copy link
Member Author

3nids commented Jan 14, 2014

Also, what would you think about moving the operators to a category in "function list"? [don't know if it's easily feasible or not]

@NathanW2

This comment has been minimized.

Copy link
Member

NathanW2 commented Jan 14, 2014

I would like to leave them were they are for now. In future being able to
assign quick buttons for functions would be nice and just have operators by
default there.

Feel free to merge.
On 14/01/2014 11:04 pm, "Denis Rouzaud" notifications@github.com wrote:

Also, what would you think about moving the operators to a category in
"function list"? [don't know if it's easily feasible or not]


Reply to this email directly or view it on GitHubhttps://github.com//pull/1073#issuecomment-32262615
.

@timlinux

This comment has been minimized.

Copy link
Member

timlinux commented Jan 14, 2014

Just noticed small violation of our HIG [1] there:

  1. Capitalise first letter only in labels:
    Labels (and group box labels) should be written as a phrase with leading
    capital letter, and all remaining words written with lower case first
    letters

So 'Function List' -> 'Function list' etc

[1] https://github.com/qgis/QGIS/blob/master/CODING#L1449

Regards

Tim

On Tue, Jan 14, 2014 at 3:06 PM, Nathan Woodrow notifications@github.comwrote:

I would like to leave them were they are for now. In future being able to
assign quick buttons for functions would be nice and just have operators
by
default there.

Feel free to merge.
On 14/01/2014 11:04 pm, "Denis Rouzaud" notifications@github.com wrote:

Also, what would you think about moving the operators to a category in
"function list"? [don't know if it's easily feasible or not]


Reply to this email directly or view it on GitHub<
https://github.com/qgis/QGIS/pull/1073#issuecomment-32262615>
.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1073#issuecomment-32262760
.

Tim Sutton - QGIS Project Steering Committee Member

Visit http://linfiniti.com to find out about:

  • QGIS programming services
  • GeoDjango web development
  • FOSS Consulting Services
    Skype: timlinux Irc: timlinux on #qgis at freenode.net

@3nids

This comment has been minimized.

Copy link
Member Author

3nids commented Jan 14, 2014

@timlinux fixed!

@3nids

This comment has been minimized.

Copy link
Member Author

3nids commented Jan 14, 2014

@NathanW2 ok. It's just that they take some place, and I personally never use them (faster to type directly). What about a collapsible group box?

@NathanW2

This comment has been minimized.

Copy link
Member

NathanW2 commented Jan 14, 2014

collapsible is fine.
On 15/01/2014 12:03 am, "Denis Rouzaud" notifications@github.com wrote:

@NathanW2 https://github.com/NathanW2 ok. It's just that they take some
place, and I personally never use them (faster to type directly). What
about a collapsible group box?


Reply to this email directly or view it on GitHubhttps://github.com//pull/1073#issuecomment-32266528
.

@timlinux

This comment has been minimized.

Copy link
Member

timlinux commented Jan 14, 2014

@3nids Thanks!

3nids added a commit that referenced this pull request Jan 14, 2014

Merge pull request #1073 from 3nids/expressiondialogsplitter
expression builder: add splitters and change buttons

@3nids 3nids merged commit 1be2674 into qgis:master Jan 14, 2014

@3nids 3nids deleted the 3nids:expressiondialogsplitter branch Jan 14, 2014

@timlinux

This comment has been minimized.

Copy link
Member

timlinux commented Jan 14, 2014

Added Changelog entry here: http://changelog.linfiniti.com/qgis/version/21/#106

PS Shouldn't the operators maintain its state between invocations of the expression dialog? Otherwise there isnt much benefit to power users?

@3nids

This comment has been minimized.

Copy link
Member Author

3nids commented Jan 14, 2014

@timlinux indeed. will do it!

@3nids

This comment has been minimized.

Copy link
Member Author

3nids commented Jan 14, 2014

@timlinux is there any existing helper to do this or should I do it on my own?

@timlinux

This comment has been minimized.

Copy link
Member

timlinux commented Jan 14, 2014

@3nids Not that I know of - just use the QSettings api to store a flag as to whether it should be collapsed or not.

Regards

Tim

@nyalldawson

This comment has been minimized.

Copy link
Contributor

nyalldawson commented Jan 14, 2014

@3nids Any chance this same change could be applied to the filter window? That window could also greatly benefit from being able to expand out the expression box.

@slarosa

This comment has been minimized.

Copy link
Member

slarosa commented Jan 14, 2014

Thanks @3nids, I think the same changes should be made to the raster calc dialog.

@3nids

This comment has been minimized.

Copy link
Member Author

3nids commented Jan 15, 2014

@timlinux found: http://qgis.org/api/classQgsCollapsibleGroupBox.html#details

@nyalldawson you mean the filter in the atlas ?

@slarosa done, will commit.

@slarosa

This comment has been minimized.

Copy link
Member

slarosa commented Jan 15, 2014

@3nids I guess @nyalldawson meant the filter window accessible from the context menu of a vector layer

@slarosa

This comment has been minimized.

Copy link
Member

slarosa commented Jan 15, 2014

@3nids the Query builder dialog
schermata del 2014-01-15 09 54 33

@3nids

This comment has been minimized.

Copy link
Member Author

3nids commented Jan 15, 2014

@slarosa thanks, done in 4502592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.