fix #13067 : bad geometries in the difference tool #2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Since it is not only about Processing, i am not merging it, in case someone has to say something abut the change in the ftools file (i guess it will be fine also, but just in case...) |
jef-n
added a commit
that referenced
this pull request
Jul 3, 2015
fix #13067 : bad geometries in the difference tool
This was referenced Jul 4, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket : http://hub.qgis.org/issues/13067
It seems that the new geometry class doesn't raise an exception if the geometry is null.
However, the "difference" algorithm was skipping the feature only if it caught an exception.
With @timlinux we decided to fix this issue by checking the validity of the geometry.