[processing] Fixed UI bug with invalid button width.

[sept-en]

Hello!

I just found small uI glitch with button (the width is too small to display text correctly).
Some screens (before and after attached).

Best regards,
Kirill Abramov.

[NathanW2]

What does it look like if you remove the max size? This will still
overflow with different font sizes.

On Fri, Mar 25, 2016 at 8:56 AM, Kirill notifications@github.com wrote:

Hello!

I just found small uI glitch with button (the width is too small to
display text correctly).
Some screens (before and after attached).

Best regards,
Kirill Abramov.

[image: qgis_modeler_bug]
https://cloud.githubusercontent.com/assets/7783792/14033595/a6ece134-f22c-11e5-9db6-61e6b21e329f.png
[image: qgis_modeler_bug_fix]

https://cloud.githubusercontent.com/assets/7783792/14033596/a708f0b8-f22c-11e5-8d3b-8b5e89b9c764.png

You can view, comment on, or merge this pull request online at:

#2945
Commit Summary

• [processing]Fixed UI bug with invalid button width.

File Changes

• M python/plugins/processing/modeler/ModelerParametersDialog.py
  https://github.com/qgis/QGIS/pull/2945/files#diff-0 (2)

Patch Links:

• https://github.com/qgis/QGIS/pull/2945.patch
• https://github.com/qgis/QGIS/pull/2945.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#2945

[sept-en]

@NathanW2 if we remove the max size, then the button will fill have the same width, as the parent component. It would be better for the big window size, but looks not so good if we reduce window's width.
So that's why I leaved setMaximumWidth() there, but just increased max width available for this.

Best regards,
Kirill Abramov.

[alexbruy]

IMHO we shouldn't limit size of UI elements as this breaks layout and it still won't work with some themes/font setting. Better to drop maximum size limit and add spacer right to the button.

[sept-en]

@alexbruy okay, I fixed it according your advices.