Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbmanager] add primary key to the view created by versioning plugin (fix #25888) #30045

Merged
merged 1 commit into from Jun 5, 2019

Conversation

@alexbruy
Copy link
Contributor

commented May 31, 2019

Description

Versioning plugin creates a view but does not include new primary key into it. As result view can not be added as a layer to QGIS. Fixes #25888

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit
@alexbruy

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

@pcav may I ask you to test this fix?

@pcav pcav changed the title [dbmanager] add promary key to the view created by versioning plugin (fix #25888) [dbmanager] add primary key to the view created by versioning plugin (fix #25888) May 31, 2019

@pcav

This comment has been minimized.

Copy link
Member

commented May 31, 2019

Checked, the id column is included.
Thanks!

@pcav pcav closed this May 31, 2019

@alexbruy alexbruy reopened this Jun 1, 2019

@alexbruy

This comment has been minimized.

Copy link
Contributor Author

commented Jun 1, 2019

@pcav I know that column included, but does it works as expected for you? Does it fixes also #22026?

And please don't close PR again.

@alexbruy alexbruy merged commit 74d6b23 into qgis:master Jun 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pcav

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

Yes, it works. Sorry for closing the PR, I assumed it was a ticket. Thanks.

@alexbruy alexbruy deleted the alexbruy:dbmanager-versioning branch Jun 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.