Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3D] On screen navigation #30105

Merged
merged 21 commits into from Jun 24, 2019

Conversation

@ismailsunni
Copy link
Contributor

ismailsunni commented Jun 6, 2019

Description

This PR is related to GSoC 2019 Project: QGIS 3D Improvement. It implements the on-screen navigation for the 3D map view. The functionalities:

  • Move up, down, left, right
  • Tilt up and down
  • Zoom in and out
  • Rotating using compass-like control
  • Tool button to show/hide the navigation widget.
  • Store its last visibility state to setting

Screenshot:
image

GIF:
3d-navigation

Issue reference: ismailsunni#1

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit
@ismailsunni ismailsunni marked this pull request as ready for review Jun 6, 2019
@ismailsunni ismailsunni changed the title [FEATURE] [need-docs] On screen navigation 3D - On screen navigation Jun 6, 2019
@wonder-sk wonder-sk added the Feature label Jun 6, 2019
@wonder-sk wonder-sk added this to the 3.10 milestone Jun 6, 2019
@wonder-sk wonder-sk changed the title 3D - On screen navigation [3D] On screen navigation Jun 6, 2019
@ismailsunni ismailsunni force-pushed the ismailsunni:on-screen-navigation branch from bf1354f to a89119e Jun 6, 2019
src/3d/qgscameracontroller.h Outdated Show resolved Hide resolved
src/3d/qgscameracontroller.h Outdated Show resolved Hide resolved
src/app/3d/qgs3dmapcanvasdockwidget.cpp Outdated Show resolved Hide resolved
src/app/3d/qgs3dnavigationwidget.cpp Outdated Show resolved Hide resolved
@nyalldawson nyalldawson added the Frozen label Jun 9, 2019
@m-kuhn m-kuhn removed the Frozen label Jun 21, 2019
@nyalldawson

This comment has been minimized.

Copy link
Contributor

nyalldawson commented Jun 23, 2019

@wonder-sk is this good to merge?

@wonder-sk wonder-sk merged commit 39fb9ce into qgis:master Jun 24, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@wonder-sk

This comment has been minimized.

Copy link
Member

wonder-sk commented Jun 24, 2019

Reviewed and tested - working nicely - great job @ismailsunni

@ismailsunni

This comment has been minimized.

Copy link
Contributor Author

ismailsunni commented Jun 25, 2019

Thanks @wonder-sk :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.