Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gui/hidpi] vectorize advanced digitizing toolbar icons #3216

Merged
merged 2 commits into from Jun 19, 2016
Merged

[gui/hidpi] vectorize advanced digitizing toolbar icons #3216

merged 2 commits into from Jun 19, 2016

Conversation

nirvn
Copy link
Contributor

@nirvn nirvn commented Jun 19, 2016

Obligatory before vs. proposed screenshot:
untitled

While this is mostly about vectorizing bitmaps, one icon was significantly changed: the merge attribute action. The previous image made little sense (glue over a blue bar?!), hopefully this new proposal works better. @nyalldawson , that should make you happy 😄

This takes care of insuring all of QGIS' toolbars are using vector images. Wouhou!

@NathanW2
Copy link
Member

Nice work. I will merge later if someone else already hasn't.

On Sun, Jun 19, 2016 at 1:30 PM, Mathieu Pellerin notifications@github.com
wrote:

Obligatory before vs. proposed screenshot:
[image: untitled]
https://cloud.githubusercontent.com/assets/1728657/16175000/6a709776-3608-11e6-94c1-0fd7ec222e31.png

While this is mostly about vectorizing bitmaps, one icon was significantly
changed: the merge attribute action. The previous image made little sense
(glue over a blue bar?!), hopefully this new proposal works better.
@nyalldawson https://github.com/nyalldawson , that should make you
happy 😄

This takes care of insuring all of QGIS' toolbars are using vector images.

Wouhou!

You can view, comment on, or merge this pull request online at:

#3216
Commit Summary

  • [gui/hidpi] vectorize advanced digitizing toolbar icons

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#3216, or mute the thread
https://github.com/notifications/unsubscribe/AAXS3KUtN-NCIb0FCJCVsyhJ-ZL5d6srks5qNLe6gaJpZM4I5FVa
.

@nirvn
Copy link
Contributor Author

nirvn commented Jun 19, 2016

Guys, please don't merge right now, I'll finish the label toolbar (didn't realize some icons were still bitmaps) and add a commit.

@nirvn
Copy link
Contributor Author

nirvn commented Jun 19, 2016 •
edited

.

@nirvn
Copy link
Contributor Author

nirvn commented Jun 19, 2016

Label toolbar, before vs. proposed:
untitled

Ready to merge.

@nyalldawson
Copy link
Collaborator

@nirvn I can see what you're doing with the vertical alignment of the label, but does it look a bit odd for the first label icon?

@nirvn
Copy link
Contributor Author

nirvn commented Jun 19, 2016

@nyalldawson it doesn't look odd to me when placed alongside other toolbars:
untitled

That said, I don't have strong feelings either way. If you think the above screenshot still bothers you, I can change it.

@nirvn
Copy link
Contributor Author

nirvn commented Jun 19, 2016

@nyalldawson , seeing that screenshot did remind of that the highlight pined label icon needs pixel alignment. Doing now.

@nirvn
Copy link
Contributor Author

nirvn commented Jun 19, 2016

Highlight pined label edit done; ready to merge (travis was green prior to retouching the SVG, safe to push).

@NathanW2 NathanW2 merged commit 29df8a9 into qgis:master Jun 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nirvn @NathanW2 @nyalldawson