Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Esri mapserver connections api #33045

Closed
wants to merge 4 commits into from

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented Nov 24, 2019

UNFINISHED for comments only

Implementation of the new connections API for web services (OGC and ESRI), the base abstract class is designed to handle a generic web service (OGC or ESRI) connection for both rasters and features, providers will need to implement their specific parts.

This initial implementation only handles AMS and AFS and it provides a partial implementation limited to connections storage and retrieval.

@elpaso elpaso added Prototype API labels Nov 24, 2019
@elpaso elpaso requested a review from nyalldawson Nov 24, 2019
Copy link
Collaborator

@nyalldawson nyalldawson left a comment

Looking good to me! One thing is that we'll need to merge the afs and ams connection classes, since a single server mixes and matches these two services in a free-form way. But I'm happy to tackle this part of it!

@stale stale bot added the stale label Dec 9, 2019
@elpaso elpaso removed the stale label Dec 9, 2019
@qgis qgis deleted a comment from stale bot Dec 9, 2019
@stale
Copy link

@stale stale bot commented Dec 23, 2019

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@stale stale bot added the stale label Dec 23, 2019
@stale
Copy link

@stale stale bot commented Dec 30, 2019

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

@stale stale bot closed this Dec 30, 2019
@gioman gioman reopened this Dec 30, 2019
@stale stale bot removed the stale label Dec 30, 2019
@github-actions github-actions bot added this to the 3.12.0 milestone Jan 10, 2020
@stale
Copy link

@stale stale bot commented Jan 24, 2020

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@stale stale bot added the stale label Jan 24, 2020
@elpaso elpaso removed the stale label Jan 24, 2020
@stale
Copy link

@stale stale bot commented Feb 7, 2020

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@stale stale bot added the stale label Feb 7, 2020
@stale
Copy link

@stale stale bot commented Feb 14, 2020

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

@stale stale bot closed this Feb 14, 2020
@gioman gioman reopened this Feb 14, 2020
@stale stale bot removed the stale label Feb 14, 2020
@nyalldawson nyalldawson removed this from the 3.12.0 milestone Feb 22, 2020
@nyalldawson nyalldawson added this to the 3.14.0 milestone Feb 22, 2020
@stale
Copy link

@stale stale bot commented Mar 7, 2020

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@stale stale bot added the stale label Mar 7, 2020
@stale
Copy link

@stale stale bot commented Mar 14, 2020

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

@stale stale bot closed this Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Prototype stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants