Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] User expressions followup #33462

Merged
merged 4 commits into from Dec 18, 2019

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented Dec 18, 2019

Followup #33437

  • renamed the group to "User expressions"
  • added help text for the group
  • added QgsSettings Expressions namespace
  • reworded tooltips for store/remove actions

user-expressions

- renamed the group to "User"
- added help text for the group
- added QgsSettings Expressions namespace
- reworded tooltips for store/remove actions
@elpaso elpaso added this to the 3.12.0 milestone Dec 18, 2019
@SrNetoChan
Copy link
Member

@elpaso are the custom functions created in python also stored in here? In qgis 3.10 they seem to appear in a "custom" group. I am wandering if we shouldn't keep that name only for the functions and not stored expressions.

@elpaso
Copy link
Contributor Author

elpaso commented Dec 18, 2019

What do you mean? The name here is "User" not "Custom".

... and avoid loading recent exp and fields twice
@SrNetoChan
Copy link
Member

Bu the help says it stores custom functions. And then there can be a "custom" group that where the custom python functions will show.

That's why I asked. When, in that group help, you say it contains "custom functions" what do you mean with that?

@elpaso
Copy link
Contributor Author

elpaso commented Dec 18, 2019

What do you suggest? Drop "custom" to avoid confusion?

@SrNetoChan
Copy link
Member

If there's no functions in there, I wouldn't mention custom fuctions. Just "user's saved expressions"

@m-kuhn
Copy link
Member

m-kuhn commented Dec 18, 2019

Did you consider "User Expressions" as discussed in the original PR?

@elpaso
Copy link
Contributor Author

elpaso commented Dec 18, 2019

Using "expressions" in an expression list seemed redundant to me.

@SrNetoChan
Copy link
Member

Actually, the list is of functions, not expressions :-p.

But the same happen with the "recent" group

@elpaso
Copy link
Contributor Author

elpaso commented Dec 18, 2019

ok, let's settle back to "User expressions"

@m-kuhn
Copy link
Member

m-kuhn commented Dec 18, 2019

I wouldn't mind "recent expressions" either, but the term recent already has less ambiguity than the term user.

As it currently stands, my first expectation for the content would be user name, user profile folder, ...

@roya0045
Copy link
Contributor

What about "Saved expressions"? It is what they are, recent implies that they are the latest, whereas saved expression is straightforward as those have been explicitly saved by the user. (Unless this is not related to the work in the other PR).

@pigreco
Copy link
Sponsor Contributor

pigreco commented Dec 18, 2019

@roya0045

What about "Saved expressions"?

in the QEP it is really so

@roya0045
Copy link
Contributor

roya0045 commented Dec 18, 2019

@roya0045

What about "Saved expressions"?

in the QEP it is really so

I guess we could have one named 'saved expression' and the other 'stored expression', where one would refer to expressions explicitly saved by a user whereas stored expressions would be expression stored in a project.This would ensure that people don't mix up either if we consider the other implementation discussed in the other PR.

Edit: what I am proposing seems to be the reverse of the nomenclature used in the QEP and the PR but it feels more natural to me.

@elpaso elpaso merged commit ecff2e6 into qgis:master Dec 18, 2019
@elpaso elpaso deleted the stored-expressions-no-groups branch December 18, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants