Rework Qgs(Double)SpinBox clear handling #3468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the widget gracefully handles shrinking
and have clearing the widget reset to default rather than null
Fixes issues with the current approach: - poor appearance on certain environments (esp OSX) - large area on spin boxes' right which "swallows" clicks and blocks interactivity Fix qgis#12920
Agreed. Thanks for tackling this. |
|
Oh, getting rid of the dead area is most welcome in the context of narrow style dock too. No more digits cut away by white empty space! |
|
I'll merge and backport to master_2 for more testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current approach used by Qgs(Double)SpinBox of having a child tool button for the clear button has some issues:
This PR reworks the spin boxes to use QgsFilterLineEdit for handling the drawing and click detection for the clear button.
Here's a before/after on OSX:
I've always hated seeing screenshots of QGIS on OSX because of this issue...