Update GridLine.py #3547

Closed
wants to merge 3 commits into
from

Projects

None yet

6 participants

@lbartoletti

Add an overlay option

@lbartoletti lbartoletti Update GridLine.py
Add an overlay option
81da544
- x = originX + (col * hSpacing)
+ x = originX
+
+ for col in xrange(start, _cols+1):
@m-kuhn
m-kuhn Oct 1, 2016 Member

I think Python 3 doesn't know xrange (and python 3 is the target of master)

@m-kuhn
m-kuhn Oct 6, 2016 Member

@lbartoletti did you test this on QGIS master?

@lbartoletti
lbartoletti Oct 19, 2016

You are right. I tested on 2.14 and 2.16, not with master and python3 (same for GridPolygon).
range() now behaves like xrange() so normally just change xrange to range. But I haven't yet tested it.

@luzpaz
luzpaz commented Nov 14, 2016

any news on when this gets merged ?

+
+ if hSpacing <= hOverlay or vSpacing <= vOverlay:
+ raise GeoAlgorithmExecutionException(
+ self.tr('Invalid overaly: %s/%s' % (hOverlay, vOverlay)))
@nyalldawson
nyalldawson Nov 14, 2016 Contributor

"overaly" -> "overlay"

@nyalldawson nyalldawson referenced this pull request Nov 14, 2016
Closed

Update GridPolygon.py #3546

@luzpaz
luzpaz commented Nov 19, 2016

out of my scope, perhaps @lbartoletti can do it ?

@nyalldawson
Contributor

@lbartoletti can you please rebase this against master so that we can merge? (also #3546 too)

@nyalldawson
Contributor

@lbartoletti thanks for the updates. This PR has merge conflicts which prevent it being merged - can you please fix these?

@lbartoletti

Yes, I will be more reactive for this...
However, is it really necessary to add "coord" field? I think it's redundant with left/right, top/bottom fields, no?

@lbartoletti lbartoletti referenced this pull request Jan 2, 2017
Open

Grid overlay #3934

@lbartoletti

Closed, look at #3934

@lbartoletti lbartoletti closed this Jan 2, 2017
@lbartoletti lbartoletti deleted the lbartoletti:patch-2 branch Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment