New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch external browser if CA sslError. Partial fix for #15617 #3671

Closed
wants to merge 4 commits into
base: release-2_18
from

Conversation

Projects
None yet
3 participants
@luipir
Contributor

luipir commented Oct 25, 2016

(reopening of #3639 rebased on release-2_18)

This PR partially fix: https://hub.qgis.org/issues/15617
"Partially" because due to this issue: https://hub.qgis.org/issues/15687 that I wasn't able to solve and debug, it is not possible to "trasparently" add CAs and a qgis restart will be asked to the user.

This PR is Windows platform specific, and new button and sslError messages are showed only in Win platform.

Due to UX (button and message) modifications the PR will require a new translation round.

@nyalldawson

This comment has been minimized.

Show comment
Hide comment
@nyalldawson

nyalldawson Mar 24, 2017

Contributor

@luipir what's the status here? (and #3640).

Contributor

nyalldawson commented Mar 24, 2017

@luipir what's the status here? (and #3640).

@luipir

This comment has been minimized.

Show comment
Hide comment
@luipir

luipir May 22, 2017

Contributor

@dakcarto is it still necessary this PR? if so, would make sense to merge for 2.18 and add string translation of the button.
@nyalldawson sorry for the delay answering :/. Btw I closed #3640 becase was for 2.14.

Contributor

luipir commented May 22, 2017

@dakcarto is it still necessary this PR? if so, would make sense to merge for 2.18 and add string translation of the button.
@nyalldawson sorry for the delay answering :/. Btw I closed #3640 becase was for 2.14.

@luipir

This comment has been minimized.

Show comment
Hide comment
@luipir

luipir Sep 5, 2017

Contributor

@nyalldawson in some days I'll revamp this PR changing the code using an embedded solution suggested by @dakcarto using WinHttpConnect instead of opening an external WinApi capable browser.
Obviously will be updated to 2.18.

Contributor

luipir commented Sep 5, 2017

@nyalldawson in some days I'll revamp this PR changing the code using an embedded solution suggested by @dakcarto using WinHttpConnect instead of opening an external WinApi capable browser.
Obviously will be updated to 2.18.

@m-kuhn

This comment has been minimized.

Show comment
Hide comment
@m-kuhn

m-kuhn May 7, 2018

Member

@luipir what's the status on this? is this still required / worked on?

Member

m-kuhn commented May 7, 2018

@luipir what's the status on this? is this still required / worked on?

@luipir

This comment has been minimized.

Show comment
Hide comment
@luipir

luipir May 7, 2018

Contributor

probably is still required (on 2.18/win). many month ago, @dakcarto worked in a simolified solution to avoid to open a CAPI compatible browser to update CAs. No idea what is the state of this and if boundless shared a simplified solution.
This PR is a suboptimal solution to a not so frequent and not critical issue. IMHO can be archived. What your opinion?

Contributor

luipir commented May 7, 2018

probably is still required (on 2.18/win). many month ago, @dakcarto worked in a simolified solution to avoid to open a CAPI compatible browser to update CAs. No idea what is the state of this and if boundless shared a simplified solution.
This PR is a suboptimal solution to a not so frequent and not critical issue. IMHO can be archived. What your opinion?

@m-kuhn

This comment has been minimized.

Show comment
Hide comment
@m-kuhn

m-kuhn May 7, 2018

Member

No opinion, I don't know the topic. I was just trying to move or cleanup some old pull requests. Happy to close it if no further work is expected. @dakcarto (or anyone) can still open a new pull request anytime if the topic is important enough for them.

Member

m-kuhn commented May 7, 2018

No opinion, I don't know the topic. I was just trying to move or cleanup some old pull requests. Happy to close it if no further work is expected. @dakcarto (or anyone) can still open a new pull request anytime if the topic is important enough for them.

@m-kuhn m-kuhn closed this May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment