Reactivate (some) WMS GetPrint unit tests #37179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you think @rldhont? |
|
@pblottiere great news, I was on the same way. |
rldhont
approved these changes
Jun 13, 2020
pblottiere
force-pushed
the
reactivate_wms_getprint
branch
from
b0158c2
to
f87fc85
Compare
|
Still segfaulting... |
|
Crossed fingers... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
After some experimentation with Travis, it seems that 3 tests are actually flaky and cause a segfault:
test_wms_getprint_atlas_getProjectSettingstest_wms_getprint_atlastest_wms_getprint_two_mapsHowever, segfault doesn't seem to be happening when these tests are executed alone. I didn't find the origin of the segfault but I'd like to reactivate all the other tests to have a basic test coverage for the WMS
GetPrintrequest.