Reactivate WMS GetPrint unit tests #37403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rldhont
added
Needs Backporting
Server
|
It's probably too annoying to fix now, but the reason these tests are so slow is that they use 300 DPI outputs. All the main layout checks (non server) drop the output DPI to keep the reference images small, and it greatly speeds up the reference/rendered comparison (simply due to much lower pixel count to check through!) |
nyalldawson
approved these changes
Jun 25, 2020
|
Travis is green ! |
Awesome :) |
|
@rldhont excellent! What was exactly the problem? |
|
Great news!
Any chance you can move another test? It's pretty close to 55 seconds... |
The duration of the test, too much tests, too long. |
rldhont
force-pushed
the
tests-reactivate-server-wms-getprint
branch
from
927d034 to
b7f620f
Compare
|
@Gustry I have added an other split |
This was referenced Jun 26, 2020
[Backport release-3_10] Fix regression in QGIS Server WMS GetPrint request with a group layer
#37425
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since #35277 [Tests][Server] WMS GetPrint group, the QGIS Server WMS GetPrint tests segfault because it takes too long time. The max duration of a test is 55 sec fc561d0 and the QGIS Server WMS GetPrint takes more than 55 sec to finish. The test was also too big.
The solution is to split the QGIS Server WMS GetPrint tests.