Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactivate WMS GetPrint unit tests #37403

Merged
merged 5 commits into from Jun 26, 2020

Conversation

rldhont
Copy link
Contributor

@rldhont rldhont commented Jun 25, 2020

Description

Since #35277 [Tests][Server] WMS GetPrint group, the QGIS Server WMS GetPrint tests segfault because it takes too long time. The max duration of a test is 55 sec fc561d0 and the QGIS Server WMS GetPrint takes more than 55 sec to finish. The test was also too big.

The solution is to split the QGIS Server WMS GetPrint tests.

@rldhont rldhont added Needs Backporting Server testsuite backport release-3_14 labels Jun 25, 2020
@rldhont rldhont added this to the 3.16.0 milestone Jun 25, 2020
@nyalldawson
Copy link
Collaborator

nyalldawson commented Jun 25, 2020

It's probably too annoying to fix now, but the reason these tests are so slow is that they use 300 DPI outputs. All the main layout checks (non server) drop the output DPI to keep the reference images small, and it greatly speeds up the reference/rendered comparison (simply due to much lower pixel count to check through!)

Copy link
Collaborator

@nyalldawson nyalldawson left a comment

Lgtm, let's give it a try!

@rldhont
Copy link
Contributor Author

rldhont commented Jun 25, 2020

Travis is green !

@pblottiere
Copy link
Member

pblottiere commented Jun 25, 2020

Travis is green !

Awesome :)

@elpaso
Copy link
Contributor

elpaso commented Jun 25, 2020

@rldhont excellent! What was exactly the problem?

@Gustry
Copy link
Contributor

Gustry commented Jun 25, 2020

Great news!

611/648 Test #611: PyQgsServerWMSGetPrint ............................ Passed 51.32 sec

Any chance you can move another test? It's pretty close to 55 seconds...

@rldhont
Copy link
Contributor Author

rldhont commented Jun 25, 2020

@rldhont excellent! What was exactly the problem?

The duration of the test, too much tests, too long.

@rldhont rldhont force-pushed the tests-reactivate-server-wms-getprint branch from 927d034 to b7f620f Compare Jun 25, 2020
@rldhont
Copy link
Contributor Author

rldhont commented Jun 25, 2020

@Gustry I have added an other split

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Backporting Server testsuite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants