Add options to dynamically tweak dash pattern in simple line symbol layers #37840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyalldawson
added
Feature
Symbology
zacharlie
added
the
Changelog
nyalldawson
force-pushed
the
line_pattern_dash
branch
2 times, most recently
from
65b810d
to
0d791bb
Compare
in simple line symbol layers New options are: - Align dash pattern to line length: If checked, the dash pattern lengths will be subtely adjusted in order to ensure that when a line is rendered it will end with a complete dash element, instead of a gap element or partial dash element - Tweak dash pattern at sharp corners: If checked, this option dynamically adjusts the dash pattern placement so that sharp corners are represented by a full dash element coming into and out of the sharp corner. It's designed to better represent the underlying geometry while rendering dashed lines, especially for jagged lines
nyalldawson
force-pushed
the
line_pattern_dash
branch
from
0d791bb
to
ace0d4e
Compare
|
Thanks for the review @nirvn! |
zacharlie
added
ChangelogHarvested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New options are:
Align dash pattern to line length: If checked, the dash pattern lengths
will be subtely adjusted in order to ensure that when a line is rendered
it will end with a complete dash element, instead of a gap element or
partial dash element
Tweak dash pattern at sharp corners: If checked, this option dynamically
adjusts the dash pattern placement so that sharp corners are represented
by a full dash element coming into and out of the sharp corner. It's designed
to better represent the underlying geometry while rendering dashed lines,
especially for jagged lines
Screenshots:
Before, showing yellow lines at actual start and end of features -- the dash pattern ends with a gap, which hides the true length of the line:
With the new "Align dash pattern to line length" option checked:
Here's an animation showing the new "tweak dash pattern at sharp corners" option being toggled: