Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spelling #37849

Merged
merged 5 commits into from Jul 21, 2020
Merged

Fix spelling #37849

merged 5 commits into from Jul 21, 2020

Conversation

PeterPetrik
Copy link
Contributor

only remaining bits are in QgsSettings where we use "browser/favourites" (follow up for #33679 (comment))

@PeterPetrik PeterPetrik requested a review from elpaso July 16, 2020 13:46
@PeterPetrik PeterPetrik mentioned this pull request Jul 16, 2020
Merged
@github-actions github-actions bot added this to the 3.16.0 milestone Jul 16, 2020
@m-kuhn
Copy link
Member

m-kuhn commented Jul 16, 2020

Looks good.
Can you add it to scripts/spell_checks/spelling.dat too?

DelazJ
DelazJ reviewed Jul 16, 2020
View reviewed changes
src/core/qgsbrowserproxymodel.h Outdated Show resolved Hide resolved
src/core/qgsbrowserproxymodel.h Outdated Show resolved Hide resolved
m-kuhn
m-kuhn approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@m-kuhn m-kuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🎉

@m-kuhn m-kuhn changed the title renamed Favourites->Favorites Fix spelling Jul 17, 2020
@PeterPetrik PeterPetrik merged commit d9f18cc into qgis:master Jul 21, 2020
@PeterPetrik PeterPetrik deleted the fix_browser_disable branch July 21, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyalldawson nyalldawson nyalldawson left review comments

@DelazJ DelazJ DelazJ left review comments

@elpaso elpaso elpaso approved these changes

@m-kuhn m-kuhn m-kuhn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PeterPetrik @m-kuhn @elpaso @nyalldawson @DelazJ