New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace QgsMapRenderer #3809

Merged
merged 2 commits into from Dec 12, 2016

Conversation

Projects
None yet
6 participants
@pblottiere
Member

pblottiere commented Nov 28, 2016

The aim of this PR is to remove the QgsMapRenderer by using QgsMapRendererCustomPainterJob for qgis/QGIS-Enhancement-Proposals#74.

Moreover, some unit tests have been added.

My starting point was this PR made by @mhugent : #3129

Note that I wanted to use

renderJob.start();
renderJob.waitForFinished()

But there's some timeout in unit tests... So I used renderJob.renderSynchronously(); instead.

Let me know if you have any comments!

@nyalldawson

Fantastic work @mhugent and @pblottiere -- looks good to me and great to see the extra tests added too

Show outdated Hide outdated python/server/qgsmsutils.sip
Show outdated Hide outdated python/server/qgsmsutils.sip
Show outdated Hide outdated src/core/qgsmaprendererjob.h
Show outdated Hide outdated src/server/qgsserver.cpp
Show outdated Hide outdated src/server/qgssldconfigparser.cpp
Show outdated Hide outdated src/server/qgswmsserver.cpp
Show outdated Hide outdated src/server/qgswmsserver.cpp
Show outdated Hide outdated src/server/qgswmsserver.cpp

@nyalldawson nyalldawson referenced this pull request Nov 28, 2016

Closed

Server renderjob #3129

@nyalldawson

This comment has been minimized.

Show comment
Hide comment
@nyalldawson

nyalldawson Nov 30, 2016

Contributor

Looks great to me! +1 from my side, but a review by @wonder-sk would be good too.

Contributor

nyalldawson commented Nov 30, 2016

Looks great to me! +1 from my side, but a review by @wonder-sk would be good too.

@wonder-sk

Great stuff - apart from few comments/questions I have the PR looks good to me.

Show outdated Hide outdated src/server/qgswmsserver.cpp
Show outdated Hide outdated src/server/qgswmsserver.cpp
Show outdated Hide outdated src/server/qgswmsserver.cpp
Show outdated Hide outdated python/server/server.sip
Show outdated Hide outdated src/server/qgsserver.h
@pblottiere

This comment has been minimized.

Show comment
Hide comment
@pblottiere

pblottiere Dec 2, 2016

Member

@nyalldawson @m-kuhn @wonder-sk

Thank you for your comments! I've updated the code accordingly.

Member

pblottiere commented Dec 2, 2016

@nyalldawson @m-kuhn @wonder-sk

Thank you for your comments! I've updated the code accordingly.

@rldhont rldhont referenced this pull request Dec 6, 2016

Open

QEP 74: QGIS server code refactoring for QGIS 3.0 #74

9 of 9 tasks complete

@rldhont rldhont merged commit 7028eee into qgis:master Dec 12, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment