New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project refactoring - part I #3855

Merged
merged 7 commits into from Dec 11, 2016

Conversation

Projects
None yet
4 participants
@wonder-sk
Member

wonder-sk commented Dec 11, 2016

Large amount of changes here, but nothing super exciting here yet. Interesting bits:

  • QgsMapLayerRegistry merged into QgsProject
  • QgsMapSettings, QgsComposerMap switched from layer IDs to weak pointers with QPointer
  • started to remove QgsProject::instance()->addMapLayers(...) where not necessary in tests
  • QgsMapThemeCollection simplified the theme storage and API and switched to weak pointers
@nyalldawson

This comment has been minimized.

Show comment
Hide comment
@nyalldawson

nyalldawson Dec 11, 2016

I'd like to see unit tests for these 3 methods

nyalldawson commented on src/core/qgsmaplayerlistutils.h in 5fc10d6 Dec 11, 2016

I'd like to see unit tests for these 3 methods

@nyalldawson

This comment has been minimized.

Show comment
Hide comment
@nyalldawson

nyalldawson Dec 11, 2016

Contributor

Looks great! Love it

Contributor

nyalldawson commented Dec 11, 2016

Looks great! Love it

@wonder-sk

This comment has been minimized.

Show comment
Hide comment
@wonder-sk

wonder-sk Dec 11, 2016

Member

Thanks for the review! I will add the unit tests and merge...

Member

wonder-sk commented Dec 11, 2016

Thanks for the review! I will add the unit tests and merge...

@wonder-sk wonder-sk merged commit 20cdd4f into qgis:master Dec 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nyalldawson

This comment has been minimized.

Show comment
Hide comment
@nyalldawson

nyalldawson Dec 11, 2016

Contributor

Really exciting stuff... Qgis 3 is going to be fantastic!

Contributor

nyalldawson commented Dec 11, 2016

Really exciting stuff... Qgis 3 is going to be fantastic!

@m-kuhn

This comment has been minimized.

Show comment
Hide comment
@m-kuhn

m-kuhn Dec 12, 2016

Member

Nice job, @wonder-sk !
Thanks for tackling this 🎉

Member

m-kuhn commented Dec 12, 2016

Nice job, @wonder-sk !
Thanks for tackling this 🎉

@mhugo

This comment has been minimized.

Show comment
Hide comment
@mhugo

mhugo Dec 13, 2016

Contributor

Great ! Thanks !

Contributor

mhugo commented Dec 13, 2016

Great ! Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment