Join GitHub today
Implements service modules registry - Experimental #3866
Implementation for qgis/QGIS-Enhancement-Proposals#74
What is done so far:
Nice work - well done - looking for more :-)
Do I understand correctly that the request/response classes will have some implementations provided in the server (e.g. impl based on QNetworkRequest/QNetworkReply and impl working with just memory buffers) ?
Hi I don't understand exactly what is the problem: nothing has changed from the plugin point of view as response was always handled with https://github.com/qgis/QGIS/blob/master/src/server/qgsrequesthandler.h that is provided from QgsServerInterface.…
Le 20 avr. 2017 à 17:20, Alessandro Pasotti ***@***.***> a écrit : @dmarteau <https://github.com/dmarteau> I just noticed that this is gone: we absolutely need it back in some way, the possibility to alter the response body from the plugins is a core feature. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <64fc56c#commitcomment-21839569>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABvOTp1y1D4X0qXZQJpUUS87lOq-qWrCks5rx3fbgaJpZM4NDLxP>.
What you have changed is:
Before you removed it, it was possible to alter (get/set) the response body by replacing it completely (which is still possible with
I see that there is now the
To keep API compatibility, we need:
Please don't forget the bindings and I'll eventually add some tests.
@dmarteau sure, that is exactly the reason why I implemented
Method called when the QgsRequestHandler sends its data to FCGI stdout. This normally occours at the end of core services processing just after the responseComplete() plugin hook. For streaming services (like WFS on getFeature requests, sendResponse() might have been called several times before the response is complete: in this particular case, sendResponse() is called once for each feature before hitting responseComplete()
I now that is far from ideal, but this is really the only way it can work with streaming services, where you might want to be able to modify the chunks before they are sent over the wire.
BTW are you available on IRC/Gitter or any other chat system?