Translate qgis::fieldcalculator to C++ #38695
Conversation
There was a problem hiding this comment.
Given the improvements of a stable C++ algorithm over the python one and the previous implementation in #38675 being discouraged at the moment, I am in favor of merging this one with the minimal UI change for now and continuing the discussion for an improved user interface in parallel.
Are there any tests for this algorithm already?
|
I have added an additional test. Good you mentioned the tests, it was not exactly backwards compatible. Now all should be good. |
| INPUT: | ||
| name: points.gml | ||
| type: vector | ||
| NEW_FIELD_NAME: test |
There was a problem hiding this comment.
@suricactus the old algorithm used FIELD_NAME as input, is there a safe way to have this backwards compatible?
There was a problem hiding this comment.
Did you encounter an issue? This should keep the backwards compatibility. The old test is passing too?
https://github.com/qgis/QGIS/pull/38695/files#diff-53600f4cb9f762166bd6d0f4d56f555cR125-R135
The qgis:fieldcalculator algorithm is currently written in Python and consists of rather custom UI. This PR attempts to translate the algorithm to a C++ implementation, aiming at speed, compatibility.
The UI slightly changes from the previous implementation, having to custom UI widgets. There is a bit of inconvinience that both "Result in" fields are optional, but I don't find a way to make them either required. This is well noted in the algorithm description.
A simpler version of #38675 , that targets only the algorithm.