Jump to conversation
Unresolved conversations (14)
@vmora vmora Feb 6, 2017
I second @wonder-sk, no need to introduce Qgis::SCALE_PRECISION, it's only used in one place and doesn't clarify the code.
src/core/qgis.cpp
vmora
@vmora vmora Jan 16, 2017
addZvalue() should be sufficient.
Outdated
src/gui/qgsmaptoolcapture.cpp
@vmora vmora Jan 16, 2017
I don't see why, while specifying that this is a PointZ, we still must give the default z-value. The ctor is the best place for init with defaults.
src/app/qgsmaptooladdfeature.cpp
haubourg m-kuhn
nyalldawson
@vmora vmora Jan 16, 2017
IMO the 3rd value in QgsPointV2 ctor should be Z coordinate. Or implicit conversion from {x,y,z}. That, or a QgsPointV2::createWithZ(real, real, real) static.
src/app/nodetool/qgsmaptoolnodetool.cpp
@vmora vmora Jan 16, 2017
do we need to expose that here if it's a global setting ?
python/gui/qgsmaptooledit.sip
@m-kuhn m-kuhn Jan 8, 2017
I guess that should be `double defaultZValue() const;`?
Outdated
src/gui/qgsmaptooledit.h
alisovenko
@m-kuhn m-kuhn Jan 8, 2017
Can we change `p` to `point`? It would be nice to have a more verbose api in 3.0. Is that point changed within the method? If not, that should be `const QgsPointV2& point`
Outdated
src/core/geometry/qgsgeometry.h
alisovenko
@haubourg haubourg Jan 2, 2017
Hi, that could be rename from "Geometries with Z coordinate" to "Geometries with Z/M coordinate" since M is also saved apparently
src/ui/qgsnewvectorlayerdialogbase.ui
@nyalldawson nyalldawson Dec 27, 2016
Nicer ui would be to disable (and clear) the mGeometryWithZCheckBox checkbox if the geometry type is set to none by the user.
src/gui/qgsnewmemorylayerdialog.cpp
nyalldawson alisovenko
@nyalldawson nyalldawson Dec 27, 2016
This won't work - geomType will never be null. It should be instead: if ( geometryType == QgsWkbTypes::NoGeometry )
src/gui/qgsnewmemorylayerdialog.cpp
nyalldawson alisovenko
@nyalldawson nyalldawson Dec 27, 2016
QGIS convention is not to name getters with a "get" prefix. This should be: double defaultZValue() const;
Outdated
src/gui/qgsmaptoolcapture.h
alisovenko
@nyalldawson nyalldawson Dec 27, 2016
"default". A description of when this is used and how it is set would also be useful.
Outdated
src/gui/qgsmaptoolcapture.h
alisovenko
@nyalldawson nyalldawson Dec 27, 2016
Seems odd to me to store this value in a member variable. Why not just modify getDefaultZValue() to retrieve the settings value? This would allow the default to be changed and immediately reflected.
Outdated
src/gui/qgsmaptoolcapture.cpp
alisovenko
@nyalldawson nyalldawson Dec 26, 2016
Can you add a description of what this constant represents to the docs
Outdated
src/core/qgis.h
alisovenko
Resolved conversations (0)