Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raster paletted/unique float support #39088

Merged
merged 4 commits into from Oct 5, 2020

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented Sep 29, 2020

Fixes #39058 an adds some small improvements in the
progress feedback.

This is technically an API change, even if it's small I'm not sure we can merge it now, I could create another ctor for Python API if needed.

@elpaso elpaso added Rasters Related to general raster layer handling (not specific data formats) Bug Either a bug report, or a bug fix. Let's hope for the latter! labels Sep 29, 2020
@github-actions github-actions bot added this to the 3.16.0 milestone Sep 29, 2020
Fixes qgis#39058 an adds some small improvements in the
progress feedback.
@elpaso elpaso force-pushed the bugfix-gh39058-raster-float-palette branch from fe3cde7 to 980659c Compare September 29, 2020 17:41
Also, makes it possible to interrupt the block reading
and makes the feedback reporting much more precise and
smoother, at the cost of a bit slower execution.
@nyalldawson
Copy link
Collaborator

This is technically an API change, even if it's small I'm not sure we can merge it now, I could create another ctor for Python API if needed.

I don't think that's an issue here

@nyalldawson nyalldawson merged commit 26160a1 into qgis:master Oct 5, 2020
@elpaso elpaso deleted the bugfix-gh39058-raster-float-palette branch October 6, 2020 05:29
@PedroVenancio
Copy link
Contributor

@elpaso This is working great with floats in 3.16.

The only thing I see is that the legend is not ordered by value:

imagem

imagem

It can be manually reordered, so, nothing problematic.

@elpaso
Copy link
Contributor Author

elpaso commented Oct 28, 2020

Can you file another ticket for the ordering issue please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Rasters Related to general raster layer handling (not specific data formats)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong assignments of raster values to symbology Paletted/Unique values or Singleband Pseudocolor
3 participants