New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raster paletted/unique float support #39088
Merged
nyalldawson
merged 4 commits into
qgis:master
from
elpaso:bugfix-gh39058-raster-float-palette
Oct 5, 2020
Merged
Raster paletted/unique float support #39088
nyalldawson
merged 4 commits into
qgis:master
from
elpaso:bugfix-gh39058-raster-float-palette
Oct 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elpaso
added
Rasters
Related to general raster layer handling (not specific data formats)
Bug
Either a bug report, or a bug fix. Let's hope for the latter!
labels
Sep 29, 2020
Fixes qgis#39058 an adds some small improvements in the progress feedback.
elpaso
force-pushed
the
bugfix-gh39058-raster-float-palette
branch
from
September 29, 2020 17:41
fe3cde7
to
980659c
Compare
Also, makes it possible to interrupt the block reading and makes the feedback reporting much more precise and smoother, at the cost of a bit slower execution.
nyalldawson
reviewed
Oct 5, 2020
I don't think that's an issue here |
nyalldawson
approved these changes
Oct 5, 2020
@elpaso This is working great with floats in 3.16. The only thing I see is that the legend is not ordered by value: It can be manually reordered, so, nothing problematic. |
Can you file another ticket for the ordering issue please? |
This was referenced Oct 28, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39058 an adds some small improvements in the
progress feedback.
This is technically an API change, even if it's small I'm not sure we can merge it now, I could create another ctor for Python API if needed.