New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code moved to wms service #3974

Merged
merged 1 commit into from Jan 10, 2017

Conversation

Projects
None yet
4 participants
@dmarteau
Contributor

dmarteau commented Jan 10, 2017

Remove specific WMS code moved to service module.

@rldhont rldhont requested review from elpaso, mhugent and rldhont Jan 10, 2017

@rldhont rldhont added this to the QGIS 3 milestone Jan 10, 2017

@elpaso

elpaso approved these changes Jan 10, 2017

I agree that the WMS methods do not belong to the request handler class. +1 to move (I assume but did not check that the functionality is now in a service class).

@dmarteau

This comment has been minimized.

Show comment
Hide comment
@dmarteau

dmarteau Jan 10, 2017

Contributor

@elpaso The code has been moved as function helpers in wms module, so this is just dead code.

Contributor

dmarteau commented Jan 10, 2017

@elpaso The code has been moved as function helpers in wms module, so this is just dead code.

@rldhont rldhont merged commit 243f01c into qgis:master Jan 10, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dmarteau dmarteau deleted the dmarteau:cleanup_qgsrequesthandler branch Jan 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment