Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

[FEATURE] Side Editor for Python Console #399

Merged
merged 9 commits into from

5 participants

@slarosa
Collaborator

A simple editor to manage your scripts directly in console with syntax highlighting and code completion.

sideEditorConsoleNew

@NathanW2
Collaborator

Is it possible to reduce the margin with the line numbers in it. There seems to be a lot of padding on the left side.

@slarosa
Collaborator

Hi Nathan,

Is it possible to reduce the margin with the line numbers in it. There seems to be a lot of padding on the left side.

yes, it is. I could fix it like the image below.
sideEditorConsoleNew2

@NathanW2
Collaborator

Yes that would be good.

@slarosa
Collaborator

I got some time for reworking on this feature and done some improvement (right now only in my local branch), but I don't know if it will be merged before of upcoming 2.0.

Do you think there is any chance to merge this new feature before of the 2.0 release ? or do we have to postpone it to 2.1 ?

@timlinux
Owner

Just note that it is not currently mergable in this pull request.

+1 for merging into master as this pull request was made well before the feature freeze.

Regards

Tim

@wonder-sk wonder-sk was assigned
@slarosa
Collaborator

Thanks Tim, I rebased and added further improvements, now it should be mergable.

@mhugent
Owner

+1 for merging too

@timlinux
Owner

@slarosa great it is mergable now - @wonder-sk will you merge it or reassign it to me and I will do it?

@wonder-sk
Collaborator

@timlinux I do not have time now to review the pull request so please go ahead - I am assigning it to you.

@timlinux timlinux was assigned
@timlinux
Owner

Hi

Is there some way other than right clicking on the console to enable the editor? We need to make the functionality easily discoverable. Perhaps an icon on the toolbar?

Regards

Tim

@slarosa
Collaborator

Hi Tim,
in the latest commit I added a button on toolbar to enable/disable the editor as you suggested, much better now thanks

sideEditorToggleButton

@timlinux
Owner

Thanks. I did some more testing - I can't actually run the editor contents (see screenie below):

Screen Shot 2013-04-14 at 12 52 57 AM

I think usability wise it would be nicer to have a second dedicated toolbar for the editor panel with

Save, save as, run, new tab, close tab, cut, copy, paste icons

Having functionality that is only available from teh context menu is IMHO not very good for usability.

Regards

Tim

@slarosa
Collaborator

I'm trying to fix the run issue although I haven't no idea on why it occurs, here it runs fine.

Working to add new toolbar....

Thanks!

@slarosa
Collaborator

Hi,
I added a minimal toolbar for side editor, if that looks good to you we can merge this pull request.

sideEditorConsoNewTool

@NathanW2
Collaborator

Looks good. +1 to merge from me. On thing I think would be good to fix after the merge is the gray margin between the line numbers and the code. I would just remove it so it matches the other side.

@timlinux
Owner
@slarosa
Collaborator

Hi Tim,

Your other changes look great. The run not working is a bit of a show stopper.

when you get a chance, could you try this patch: https://gist.github.com/slarosa/5387265
Should fix the issue with interrupted system call on MAC OS.

Thanks.

@timlinux
Owner

Ok I'm testing it now....

@timlinux
Owner

Ok your patch works great for me here on osx. I think we are good to go ahead and apply your branch to master - thanks for your patience and this great new feature! Please feel free to push your changes to master with the osx patch applied.

@slarosa slarosa merged commit 0d0fd3b into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.