Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add streaming digitizing mode #42054

Merged
merged 10 commits into from
Mar 11, 2021
Merged

Add streaming digitizing mode #42054

merged 10 commits into from
Mar 11, 2021

Conversation

nyalldawson
Copy link
Collaborator

@nyalldawson nyalldawson commented Mar 5, 2021

When active, points are automatically added following the mouse cursor movement. You can quickly toggle between normal (or circular string) digitizing and streaming by hitting the "R" key mid-digitize operation.

Works with all the map tools you'd expect: digitize line/polygon, add ring, add part, reshape, split features/parts, ...!

Refs Natural resources Canada Contract: 3000720707

Peek 2021-03-05 14-42

@nyalldawson nyalldawson added Feature Digitizing Related to feature digitizing map tools or functionality Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Mar 5, 2021
@Saijin-Naib
Copy link

This is going to make digitizing with my drawing tablet so much nicer!
Thanks so much, Nyall!

@nyalldawson
Copy link
Collaborator Author

nyalldawson commented Mar 5, 2021

~~Oops. forget that I need a new icon for this tool 😆 ~~

@DelazJ DelazJ added the Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. label Mar 5, 2021
@github-actions
Copy link

github-actions bot commented Mar 5, 2021

@nyalldawson
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@github-actions github-actions bot added this to the 3.20.0 milestone Mar 5, 2021
@uclaros
Copy link
Contributor

uclaros commented Mar 5, 2021

Nice!
How does it play along with snapping and tracing?
Also, can it be used in conjunction with Digitize with curve? If not, some kind of a tri-state selector between StraightSegments, CircularString and Streaming would make sense.

@gioman
Copy link
Contributor

gioman commented Mar 5, 2021

How does it play along with snapping and tracing?

as also with "avoid overlaps".

@uclaros
Copy link
Contributor

uclaros commented Mar 5, 2021

Avoid overlaps is handled later on each tool, after digitizing is completed so it should not be affected.

When active, points are automatically added following the mouse
cursor movement.

Refs Natural resources Canada Contract: 3000720707
When the backspace key is held down, points will be repeatedly
removed from streamed digitized sections, right up till the start
of the streaming section. Then the point removal will temporarily
pause until the user releases and re-holds down the backspace key.

This allows users to selectively remove portions of the geometry
captured with the streaming mode by holding down the undo key,
without risking accidental undo of non-streamed portions.
@nyalldawson
Copy link
Collaborator Author

@uclaros

How does it play along with snapping and tracing?

Snapping works as you'd expect, but tracing is bypassed whenever streaming mode is enabled. I don't really see how these two options could work together, because tracing implies a click somewhere and then a click somewhere distant from that first point to trace between.

Also, can it be used in conjunction with Digitize with curve? If not, some kind of a tri-state selector between StraightSegments, CircularString and Streaming would make sense.

I've moved the circular string toggle into the newly introduced drop down group:

Peek 2021-03-08 10-33

Copy link
Contributor

@nirvn nirvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nyalldawson , really nice stuff (this PR and the prep PRs that preceded it).

src/gui/qgsmaptoolcapture.cpp Outdated Show resolved Hide resolved
src/gui/qgsmaptoolcapture.cpp Outdated Show resolved Hide resolved
src/gui/qgsmaptoolcapture.h Outdated Show resolved Hide resolved
@nyalldawson
Copy link
Collaborator Author

Thanks @nirvn!

@github-actions
Copy link

@nyalldawson
A documentation ticket has been opened at qgis/QGIS-Documentation#6582
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

@zacharlie zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Jun 5, 2021
@albertolozada
Copy link

Hi, I have a question. ¿How you can end the trace without right clicking and open the attributes table? Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChangelogHarvested This PR description has been harvested in the Changelog already. Digitizing Related to feature digitizing map tools or functionality Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants