Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[style dock] fix defining min/max values via raster histogram #4262

Merged
merged 1 commit into from Mar 15, 2017

Conversation

nirvn
Copy link
Contributor

@nirvn nirvn commented Mar 15, 2017

Description

This RP resurrects the setting of raster band min/max values through the style dock's histogram tab. It also switch the computation min / max widget method to "user defined" (which prevents values from being reverted to default when changing saturation / contrast / etc. values).

@rouault , @NathanW2 , are you OK with the proposed change?

P.S. @rouault , as you might have noticed, I filed a bug yesterday on min / max values broken when opening a raster layer's properties window (http://hub.qgis.org/issues/16353). This PR doesn't fix that bug, it's still in need of your attention 馃槃

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and containt sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@NathanW2
Copy link
Member

I'm happy if you are happy. I don't do raster stuff so happy to take your lead on the workflow here.

@nirvn nirvn force-pushed the style_dock_raster_histogram_fix branch from 674ee3f to fb4be9e Compare March 15, 2017 03:31
@nirvn nirvn force-pushed the style_dock_raster_histogram_fix branch from fb4be9e to 41a14c1 Compare March 15, 2017 03:40
@nirvn nirvn changed the title [style dock] fix broken raster histogram [style dock] fix defining min/max values via raster histogram Mar 15, 2017
@nirvn nirvn merged commit 4f3cf68 into qgis:master Mar 15, 2017
@nirvn
Copy link
Contributor Author

nirvn commented Mar 15, 2017

@NathanW2 , I'm happy, therefore we are happy.

@rouault
Copy link
Contributor

rouault commented Mar 29, 2017

@nirvn ef26d95 might fix some of the problems you've seen

@nirvn nirvn deleted the style_dock_raster_histogram_fix branch February 26, 2018 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants