Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processing] fix open script dialogs (fix #16347) #4276

Closed
wants to merge 1 commit into from
Closed

[processing] fix open script dialogs (fix #16347) #4276

wants to merge 1 commit into from

Conversation

ghtmtt
Copy link
Contributor

@ghtmtt ghtmtt commented Mar 17, 2017

Description

Small PR that fixes issue #16347. Ideas taken from b0dc9f8, thanks @nyalldawson :)

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and containt sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@alexbruy
Copy link
Contributor

Wiping ~/.qgis3 fixes this issue without editing code. I think this is related to recent QgsSettings switch, so IMHO there is no sense in this fix.

@ghtmtt
Copy link
Contributor Author

ghtmtt commented Mar 17, 2017

ah ok, I saw the recent commit b0dc9f8 that fixed almost the same thing for the modeler and I thought it could be useful to fix also for scripts.
Feel free to dump the PR if you think it is useless

@alexbruy
Copy link
Contributor

Sorry, not ~/.qgis3, but QGIS settings.

@ghtmtt
Copy link
Contributor Author

ghtmtt commented Mar 17, 2017

Ok, you are talking about this qgis/QGIS-Enhancement-Proposals#82 right?
Anyway, no problem, if the PR is useless dump it without problems ;)

@ghtmtt
Copy link
Contributor Author

ghtmtt commented Mar 20, 2017

@alexbruy can we close or merge this PR?

@alexbruy alexbruy closed this Mar 22, 2017
@ghtmtt
Copy link
Contributor Author

ghtmtt commented Mar 27, 2017

@alexbruy sorry for writing again. But I freshly recompiled QGIS, opened with the --configpath options but I still get the same error fixed with this PR.
I just don't understand what should I remove for fixing this without code writing. Thanks in advance!

@ghtmtt ghtmtt deleted the fix_proc_editor branch November 15, 2017 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants