[mesh] mesh frame editing part 3 - Advanced editing #44169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcloarec
force-pushed
the
advancedEditing
branch
from
f3ccc59
to
65f10b1
Compare
PeterPetrik
reviewed
Jul 15, 2021
| QgsMeshTriangulation triangulation; | ||
|
|
||
| QVector<int> triangulationVertexToMeshVertex( vertexIndextoTriangulate.count() ); | ||
| const QgsMesh destinationMesh = *meshEditor->topologicalMesh()->mesh(); |
There was a problem hiding this comment.
if it is const, cannot we just use pointer here and do not dereference it?
Yes, there are surely some other that coming, but later, not in this PR. A least, I think about the force mesh by a polyline, and maybe modify by expression. |
vcloarec
added
Feature
Mesh
vcloarec
force-pushed
the
advancedEditing
branch
from
1ebf988
to
04ad91a
Compare
vcloarec
force-pushed
the
advancedEditing
branch
from
41263cc
to
c2eccd7
Compare
|
It would be good to not use force-push git commit (only when rebasing from master) since it makes reviews harder... |
PeterPetrik
approved these changes
Jul 19, 2021
tomkralidis
pushed a commit
to tomkralidis/QGIS
that referenced
this pull request
Aug 22, 2021
[mesh] [feature] Delaunay triangulation and face refinement for advanced mesh editing tools
zacharlie
added
the
Changelog
zacharlie
added
ChangelogHarvested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in the scope of qgis/QGIS-Enhancement-Proposals#228
API:
Here, advanced editing is introduced by a new interface abstract class QgsMeshAdvancedEditing.
Derived classes of this class can be implemented to make some advanced editing on a mesh: generation of faces to add to the mesh, particular operation on many faces or vertices.
The advanced editing is made by passing a QgsMeshAdvancedEditing instance to a QgsmeshEditor instance, and the editing is applied as other editing operations.
In this PR, two advanced editings are implemented:
User interface in QGIS:
Delaunay triangulation and face refinement are accessible from the context menu in the map when vertices or/and faces are selected. Later, when other tools will be implemented, maybe these actions could be called from buttons in the mesh toolbar.