New API for traversal of geometry's vertices using iterator pattern#4513
Closed
wonder-sk wants to merge 2 commits intoqgis:masterfrom
Closed
New API for traversal of geometry's vertices using iterator pattern#4513wonder-sk wants to merge 2 commits intoqgis:masterfrom
wonder-sk wants to merge 2 commits intoqgis:masterfrom
Conversation
nyalldawson
approved these changes
May 7, 2017
Collaborator
|
Awesome! This will be very useful |
m-kuhn
approved these changes
May 7, 2017
Member
There was a problem hiding this comment.
Should there be an error message here?
Member
There was a problem hiding this comment.
Can these be prefixed with a mEmber prefix?
src/core/geometry/qgsgeometry.h
Outdated
Member
There was a problem hiding this comment.
Would be great to have a short code snippet here or on the class QgsVertexIterator
Maybe just a copy of the python test.
Member
|
Really nice stuff |
Introducing: 1. STL-style iterator: QgsAbstractGeometry::vertex_iterator 2. Java-style iterator: QgsVertexIterator (built on top of STL-style) The iterators are modeled after Qt's STL-style and Java-style iterators, the idea is to replace nextVertex() method and later introduce iterators for other bits (e.g. part_iterator, ring_iterator).
wonder-sk
force-pushed
the
vertex-iterator
branch
from
5f7903b to
fc39b81
Compare
Member
|
@wonder-sk are you planning to revive this? It will be very valuable to have this in place! |
Member
Author
|
Yeah I will update it soon... the third dimension is keeping me busy nowadays... |
Member
|
I wish it would be possible to upvote PRs ;) |
8 tasks
Collaborator
|
cough please finish this cough |
Member
Author
|
Superseded by #5365 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing:
The iterators are modeled after Qt's STL-style and Java-style iterators, the idea is to replace nextVertex() method and later introduce iterators for other bits (e.g. part_iterator, ring_iterator).