Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Server] WMS DXF writer refactoring #4687

Merged
merged 1 commit into from Jun 9, 2017

Conversation

rldhont
Copy link
Contributor

@rldhont rldhont commented Jun 6, 2017

Removing QgsWMSProjectParser from DXF writer used in GetMap with dxf format
qgis/qgis4.0_api#57

Checklist

  • Commit messages are descriptive and explain the rationale for changes
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • I have run the scripts/prepare-commit.sh script before each commit

@rldhont rldhont added the Server label Jun 6, 2017
@rldhont rldhont added this to the QGIS 3 milestone Jun 6, 2017
@rldhont
Copy link
Contributor Author

rldhont commented Jun 6, 2017

@mhugent can you check this PR ?

@mhugent
Copy link
Contributor

mhugent commented Jun 6, 2017

@rldhont: Will do, but it is going to be Thursday or Friday

@rldhont
Copy link
Contributor Author

rldhont commented Jun 7, 2017

@mhugent thanks! I will wait for your feedback.

@mhugent
Copy link
Contributor

mhugent commented Jun 9, 2017

@rldhont: the changes look good to me, +1 for merging

@rldhont
Copy link
Contributor Author

rldhont commented Jun 9, 2017

@mhugent thanks, I resolve the conflict and merge it.

@rldhont rldhont merged commit f80a1f5 into qgis:master Jun 9, 2017
@rldhont rldhont deleted the server-wms-dxf-writer branch October 19, 2017 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants