-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export pointcloud layers #49280
Export pointcloud layers #49280
Conversation
| <item row="0" column="0"> | ||
| <widget class="QLabel" name="label_5"> | ||
| <property name="text"> | ||
| <string>Limit total number of exported points to:</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <string>Limit total number of exported points to:</string> | |
| <string>Limit total number of exported points to</string> |
No colon on labels.
And unless there is a plan to add more entries, I was wondering whether we need that group box with single item (with almost the same label). Not HIG compliant. What about:
We would probably then need to move that single option somewhere upper...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a though to add a separate widget in that group that would limit the total number of points by stopping at a particular node level, resulting in a (kind of) predefined point density.
While groupboxes with single items do clutter the ui, imho in this specific case it makes sense, since it's on a list of collapsible-checkable groupboxes. Having one type of filter without a groupbox would make it look weirder and also make it stand-out like it's a more important setting.
Since the HIG says to avoid using those, I'd propose to keep it like that, if you do not insist!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a though to add a separate widget in that group that...
The you hit my "unless there is a plan to add more entries"
Having one type of filter without a groupbox would make it look weirder and also make it stand-out like it's a more important setting.
Agreed. Reason why I was suggesting to move it somewhere else (no idea which other options it could have cohabited with though)
Since the HIG says to avoid using those, I'd propose to keep it like that, if you do not insist!
No insistence. See above.
|
And question: should we consider in the future adding "Temporary scratch layer" to vector layer export types also? |
|
@uclaros A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged. Please update the description (not the comments) with helpful description and screenshot to help the work from documentors. Thank you! |
I'm not sure I completely agree with that change; it doesn't look too good when the scrollbar appears... I left a comment on your PR
This is not a bad idea! Copy and paste as a temporary scratch layer is not as straight forward as export! Doing it with lots of data would also be faster by skipping the clipboard middleman! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
|
@uclaros |


Description
This PR allows the users to export a (potentially filtered) point cloud layer to vector or point cloud formats. Current supported formats are:
Supports filtering by extent, filtering by Z range, crs re-projection and limiting the number of exported points.
Funded by: State of Vorarlberg and Swiss QGIS user group