Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Small clean-up in WMS renderer #4945

Merged
merged 2 commits into from Aug 1, 2017

Conversation

pblottiere
Copy link
Member

@pblottiere pblottiere commented Jul 31, 2017

Description

This PR makes some clean-up in WMS renderer and especially in the createImage and configureMapSettings methods.

To compare WMS versions, the QgsProjectVersion class is used and the operator >= has been fixed to be properly working.

Checklist

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and containt sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@rldhont rldhont added the Server label Aug 1, 2017
@rldhont rldhont added this to the QGIS 3 milestone Aug 1, 2017
@rldhont
Copy link
Contributor

rldhont commented Aug 1, 2017

thanks @pblottiere

@rldhont rldhont merged commit a8f6dbc into qgis:master Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants