Fix QgsNetworkAccessManager ssl error handler race condition issue #50443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troopa81
added
the
Bug
troopa81
force-pushed
the
fix_sslerror_handler
branch
from
b9df996
to
7ab26c9
Compare
This was referenced Oct 3, 2022
strk
reviewed
Oct 3, 2022
|
Thanks @troopa81 -- this has been an issue for a loooong time 👍 |
nyalldawson
approved these changes
Oct 4, 2022
troopa81
force-pushed
the
fix_sslerror_handler
branch
from
7ab26c9
to
688158f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same logic than with auth request handler #45833
It fixes randomly failing test test_core_networkmanager (here for instance)
I tested it with several iterations and random sleep in the code.
Even if I'm quite confident this won't break anything, I'm not keen on backporting it