Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native point cloud Processing provider (QEP 263) #52182

Merged
merged 26 commits into from Mar 22, 2023
Merged

Native point cloud Processing provider (QEP 263) #52182

merged 26 commits into from Mar 22, 2023

Conversation

alexbruy
Copy link
Contributor

@alexbruy alexbruy commented Mar 10, 2023

Description

Add new native Processing provider with point cloud algorithms, as described in qgis/QGIS-Enhancement-Proposals#263. Under the hood provider uses pdal_wrench command line tool.

Currently available algorithms:

  • Information: outputs a basic metadata of the point cloud (number of points, extent, crs, etc)
  • Convert format: convert point cloud to a different format, e.g. las to laz
  • Reproject: reproject point cloud to a different CRS
  • Fix projection: fix (assign) CRS of a point cloud file
  • Clip: clip point cloud by clipping polygon(s)
  • Merge: merge multiple point clouds in a single file
  • Tile: create tiles from input data
  • Thin: create a thinned version of the point cloud
  • Boundary: export vector layer containing point cloud boundaries
  • Density: export a raster file where each cell contains number of points that are in that cell's area
  • Export to raster: export point cloud data to a 2D raster grid
  • Export to vector: export point cloud data to a vector layer with 3D points
  • Export to raster (TIN): export point cloud data to a 2D raster grid using a triangulation of points
  • Filer: extract subset from the point cloud using PDAL expressions

As pdal_wrench requires PDAL >= 2.5.0, the new processing provider will be available only where the PDAL version requirement is satisfied.

Funded by: Point cloud processing crowdfunding

@alexbruy alexbruy added Feature Processing Relating to QGIS Processing framework or individual Processing algorithms Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. labels Mar 10, 2023
@github-actions
Copy link

@alexbruy
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@github-actions github-actions bot added this to the 3.32.0 milestone Mar 10, 2023
cmake/FindPDAL.cmake Outdated Show resolved Hide resolved
external/pdal_wrench/info.cpp Show resolved Hide resolved
external/pdal_wrench/main.cpp Outdated Show resolved Hide resolved
external/pdal_wrench/to_raster_tin.cpp Outdated Show resolved Hide resolved
external/pdal_wrench/translate.cpp Outdated Show resolved Hide resolved
external/pdal_wrench/translate.cpp Show resolved Hide resolved
src/analysis/processing/pdal/qgspdalalgorithmbase.cpp Outdated Show resolved Hide resolved
src/analysis/processing/pdal/qgsalgorithmpdaltile.cpp Outdated Show resolved Hide resolved
@alexbruy
Copy link
Contributor Author

clang-tidy check failed because of missed automatically generated file, that file will be generated only when building with PDAL >= 2.5

Copy link
Member

@wonder-sk wonder-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the code and tested before the PR was created, and with Nyall's comments addressed, we should be good to go!

@wonder-sk wonder-sk merged commit 7177549 into qgis:master Mar 22, 2023
26 of 27 checks passed
@github-actions
Copy link

@alexbruy
A documentation ticket has been opened at qgis/QGIS-Documentation#8122
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

@alexbruy alexbruy deleted the processing-pdal branch March 23, 2023 06:15
@zacharlie zacharlie added the Changelog Items that are queued to appear in the visual changelog - remove after harvesting label Jun 17, 2023
@qgis-bot
Copy link
Collaborator

@alexbruy

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@zacharlie zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChangelogHarvested This PR description has been harvested in the Changelog already. Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Processing Relating to QGIS Processing framework or individual Processing algorithms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants