Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trusted status from Plugin Manager #5272

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
6 participants
@DelazJ
Copy link
Contributor

commented Sep 30, 2017

Discussion at http://osgeo-org.1560.x6.nabble.com/QGIS-Developer-Reword-quot-Trusted-Plugin-quot-gt-quot-Trusted-Plugin-Author-quot-td5334047.html

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and containt sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit
@m-kuhn

m-kuhn approved these changes Oct 1, 2017

Copy link
Member

left a comment

Looks good to me code-wise

Can you comment on the functionality level about the mid-term goal.

Is the label expected to be replaced with something focussed on the author or is this the final state?

@DelazJ

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2017

Afaics no decision has been taken in the discussion. Only proposals were made so i chose the one that looked better to me, unless someone comes with a clear and short label about trusted status (and even in that case i'm not sure this information is worth showing there; it's devs internal affairs). Unless there's a system that objectively classifies all plugin authors, Imho we should avoid any label that could "segregate" plugin authors and instead focus on means to improve users' choice (the most suited plugin) :

  • promote the voting system (with a tooltip?)
  • show what's new when new version is available (to help user decide if it's worth updating)
  • show download statistics (not the total of downloads, regardless the number of versions but either the mean, the maximum... )
  • display user comments on plugins (QGIS4?)
    ...
    But maybe i'm already out of the scope of your question (and this PR)
@timlinux

This comment has been minimized.

Copy link
Member

commented Oct 1, 2017

I'm OK with hiding it from end users but still having trusted authors as a mechanism for self approval of plugins on the backend. If that is your intent +1 from me.

@DelazJ

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2017

Yes of course, we should keep the trusted mechanism in the backend. The intent of this PR is just to hide it from the users; it shouldn't do more...

@m-kuhn

This comment has been minimized.

Copy link
Member

commented Oct 2, 2017

@timlinux do you think such a change is worth a public announcement?

@borysiasty

This comment has been minimized.

Copy link
Member

commented Oct 28, 2017

+1 for removing the greens from 3.0
Especially that the trusted plugins are not always those heavy used, so users may be confused with such odd selection of 'recommended' plugins.

Please write or link any suggestions to the ML topic mentioned above or to https://issues.qgis.org/issues/17349 - otherwise we'll get lost ;)

DelazJ added some commits Oct 30, 2017

@DelazJ

This comment has been minimized.

Copy link
Contributor Author

commented Oct 30, 2017

Given recent mails in psc list, i'd like to know the status of this pr. Thanks.

@m-kuhn

This comment has been minimized.

Copy link
Member

commented Oct 30, 2017

Let's go ahead and merge, there's consensus that the current situation needs to change. We can then review better solutions as they are proposed. Thanks @DelazJ

@m-kuhn

This comment has been minimized.

Copy link
Member

commented Oct 30, 2017

Merged

@m-kuhn m-kuhn closed this Oct 30, 2017

@m-kuhn

This comment has been minimized.

Copy link
Member

commented Oct 30, 2017

I think this is worth being mentioned in the visual changelog, can we somewhere open an issue so we don't forget this?

@timlinux is there such a place/issue tracker?

@DelazJ

This comment has been minimized.

Copy link
Contributor Author

commented Oct 30, 2017

Thanks @m-kuhn
And i agree that some information/explanation should be provided for the whole community.

@DelazJ DelazJ deleted the DelazJ:trusted branch Oct 30, 2017

@Gustry

This comment has been minimized.

Copy link
Contributor

commented Oct 30, 2017

We can start editing the changelog. I added a new entry quickly: http://changelog.qgis.org/en/qgis/version/3.0.0/#remove-trusted-status-from-plugin-manager

@m-kuhn

This comment has been minimized.

Copy link
Member

commented Oct 30, 2017

Thanks @Gustry
Does that mean that this time we will not have an auto-compiled changelog from the commit history?

@jef-n

This comment has been minimized.

Copy link
Member

commented Oct 30, 2017

@m-kuhn the visual changelog is not made from the commit log.

@m-kuhn

This comment has been minimized.

Copy link
Member

commented Oct 30, 2017

@jef-n IIRC the initial import always was created (by @timlinux ?) by grepping for [FEATURE] tags

@DelazJ

This comment has been minimized.

Copy link
Contributor Author

commented Oct 31, 2017

I couldn't find the reference but i think i've recently see a call from @timlinux for help to set up the changelog so a great part ofbthe work might not be automated...

@gacarrillor gacarrillor referenced this pull request Nov 3, 2017

Merged

Developers Map: show more descriptive info #5522

2 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.