New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put GeoPackage at first place in the menu #5385
Conversation
Can you add a "[needs-docs]" tag to the commit message? The change in shortcut behavior will need to be updated in the qgis documentation |
Question: does this also fix the toolbar? |
@DelazJ should the tool bar buttons be substituted by the single add layer button ? IMHO the buttons remain just for a transition or nostalgic phase |
These are buttons to create a new layer not to add a layer... |
Oh, I was not aware of the toolbar button - ok, will fix it also for the toolbar too. Otherwise no objections? |
@jachym go ahead :) |
@luipir Order of "new file" buttons in the toolbar changed as well Anything else? |
@jachym well, while you are on it ;-) I think that is a good candidate too? |
@rduivenvoorde and @luipir I've add another commit with some other dialog changes eb964ef930a76020395a92dcc48189d256b815df can you guys review? |
I can't ckeck for all conditions, but seems it's the correct way to get rid of shapefile :)... sometimes so little PRs can have a great effect. Great :) |
@luipir or great side effect - any hint, what to do with the travis check? apparently, it's complainig about api change
|
@jachym Did you run the scripts/prepare-commit.sh before the commit? |
@Gustry well I run ok, it should be fine by now |
Some tests apparently assume shapefiles as default. |
neither do I :-( |
66 tests failing - but they do not seem to be by far related to "shp" issue :-/ |
I'm -1 on the API changes. I think changing user facing settings is fine, but changing default API methods to use gpkg is premature and may have many unintentional side effects. |
resources/qgis-resource-metadata.xml
Outdated
@@ -52,7 +52,7 @@ | |||
<links> | |||
<link name="geonode:roads" type="OGC:WMS" description="my GeoNode road layer" url="http://example.org/wms"/> | |||
<link name="geonode:roads" type="OGC:WFS" description="my GeoNode road layer" url="http://example.org/wfs"/> | |||
<link name="roads" type="WWW:LINK" description="full dataset download" url="http://example.org/roads.tgz" format="ESRI Shapefile" mimeType="application/gzip" size="283676"/> | |||
<link name="roads" type="WWW:LINK" description="full dataset download" url="http://example.org/roads.tgz" format="GPKG" mimeType="application/gzip" size="283676"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change should be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right, changed back
scripts/random_vector.py
Outdated
@@ -29,7 +29,7 @@ def error(msg): | |||
|
|||
(minx, miny, maxx, maxy) = map(float, options.extent.split(",")) | |||
|
|||
driverName = "ESRI Shapefile" | |||
driverName = "GPKG" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this change too - it's a purely test based tool, switching to gpkg has no benefit here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed back
Thank you @nyalldawson for review, any more comments? |
src/app/qgsattributeactiondialog.cpp
Outdated
@@ -306,7 +306,7 @@ void QgsAttributeActionDialog::addDefaultActions() | |||
{ | |||
int pos = 0; | |||
insertRow( pos++, QgsAction::Generic, tr( "Echo attribute's value" ), QStringLiteral( "echo \"[% \"MY_FIELD\" %]\"" ), QLatin1String( "" ), true, tr( "Attribute Value" ), QSet<QString>() << QStringLiteral( "Field" ), QString() ); | |||
insertRow( pos++, QgsAction::Generic, tr( "Run an application" ), QStringLiteral( "ogr2ogr -f \"ESRI Shapefile\" \"[% \"OUTPUT_PATH\" %]\" \"[% \"INPUT_FILE\" %]\"" ), QLatin1String( "" ), true, tr( "Run application" ), QSet<QString>() << QStringLiteral( "Feature" ) << QStringLiteral( "Canvas" ), QString() ); | |||
insertRow( pos++, QgsAction::Generic, tr( "Run an application" ), QStringLiteral( "ogr2ogr -f \"DPKG\" \"[% \"OUTPUT_PATH\" %]\" \"[% \"INPUT_FILE\" %]\"" ), QLatin1String( "" ), true, tr( "Run application" ), QSet<QString>() << QStringLiteral( "Feature" ) << QStringLiteral( "Canvas" ), QString() ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be GPKG and not DPKG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, thanks, fixed
@nyalldawson at what api change are you referring... btw I feel more confortable to this kind of api change than more new features. IMHO This will force us to fix unconsistent use fo gpkg. |
f22a524
to
f0be0fe
Compare
9e28ec2
to
d9e403a
Compare
Horray, travis passed |
Looks good to me. |
@luipir are you ok with current pull request? can you guys push, to push this to master? |
go ahead :) |
I've had to revert the changes to testqgsmaprendererjob - they've been causing hangs on Travis (see e.g. https://travis-ci.org/qgis/QGIS/jobs/290839698 ) |
OMFG, thanks a lot @m-kuhn !! |
Description
This PR puts OGC GeoPackage at first place in the "Create new vector layer" menu entry.
Checklist
fixes #11111
in the commit message next to the description[FEATURE]
in the commit message[needs-docs]
in the commit message and containt sufficient information in the commit message to be documentedscripts/prepare-commit.sh
script before each commit