Jump to conversation
Unresolved conversations (3)
@nyalldawson nyalldawson Dec 20, 2023
Does this need addressing first?
python/PyQt6/core/conversions.sip
@nyalldawson nyalldawson Dec 20, 2023
Needs addressing?
python/PyQt6/core/conversions.sip
@nyalldawson nyalldawson Dec 20, 2023
Should this be addressed first?
python/PyQt6/core/conversions.sip
Resolved conversations (2)
@nyalldawson nyalldawson Dec 20, 2023
This reads awkwardly. Could we use "ifdef SIP_PYQT5_RUN" instead?
Outdated
src/core/qgsjsonutils.h
troopa81
@nyalldawson nyalldawson Dec 20, 2023
Instead of removing the whole function, couldn't we just remove the encoding argument and force it to nullptr? There's the existing SIP_PYARGREMOVE mechanism for this, we could adapt this to a new SIP_PYARGREMOVE6 for selective removal.
...6/core/auto_generated/qgsjsonutils.sip.in
nyalldawson troopa81