Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin installer][needs-docs] Display notifications as an icon rather than a text #5952

Merged
merged 4 commits into from Dec 28, 2017

Conversation

borysiasty
Copy link
Member

As we all know, the status bar became too crowded. Especially plugin installer notifications There is a new plugin available and There is a plugin update available eat definitely too much space. See also https://lists.osgeo.org/pipermail/qgis-user/2017-December/041246.html

This PR replaces texts with icons, while the original text goes to the tooltip.

Before:
zrzut_20171226_210333

After:
zrzut_20171226_211405

On both screenshots the window length is 1280 px. All labels become readable (at least in English).

…the status bar when new a plugin or plugin upgrade is available
@m-kuhn
Copy link
Member

m-kuhn commented Dec 26, 2017

Love it

@m-kuhn
Copy link
Member

m-kuhn commented Dec 26, 2017

Maybe put it to the right, next to log messages, so we have the "notification corner" there?

@borysiasty
Copy link
Member Author

Good idea, it would look like that (there is no additional margin on the right - what you can see is just my window decoration stuff - a placeholder for the resize handle or so):
zrzut_20171226_233032

I'm falling asleep, will commit it in the morning.

@nirvn
Copy link
Contributor

nirvn commented Dec 27, 2017

Big +1

@nyalldawson
Copy link
Collaborator

Good move! Can we make the icon grayscale, to fit the rest of the status bar?

@borysiasty
Copy link
Member Author

Desaturated. It's a bit bigger than other icons in the status bar, but it seems to be too complex to scale it down without blur, so for now I'd leave it as is. Anyway, it's a notification, so it can be more prominent ;)

zrzut_20171227_225615

@nyalldawson
Copy link
Collaborator

@borysiasty

Protip: push it and if the icon is an issue, I'm sure it'll eventually raise @nirvn's ire enough for him to fix ;)

@borysiasty borysiasty merged commit 4783af6 into qgis:master Dec 28, 2017
@borysiasty
Copy link
Member Author

Hopefully one day @nirvn will forgive me ;)

@slarosa
Copy link
Member

slarosa commented Dec 28, 2017

Sorry if I am asking just after merging, but why not put the hyperlink text on a message bar information widget?

@borysiasty
Copy link
Member Author

@slarosa, at that stage I only decided to compact the existing label. Now we can discuss switching to the message bar, but my personal answer is -1:

I prefer to avoid pushing more notifications to the message bar on QGIS startup. Depending on your specific situation, you may already see a few notifications at once (a project from older qgis, macros in project, defective plugin X, defective plugin Y, probably some connection problems etc) what I find a bit annoying.

@slarosa
Copy link
Member

slarosa commented Dec 30, 2017

@borysiasty true, you're right! statusbar icon fits better.

@borysiasty borysiasty deleted the plugin-notification branch January 15, 2018 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants