[bugfix] Set missing expression context in some filters (fixes #17893) #6118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyalldawson
reviewed
Jan 20, 2018
src/core/layout/qgslayoutatlas.cpp
Outdated
| @@ -234,6 +234,9 @@ int QgsLayoutAtlas::updateFeatures() | |||
| req.setFilterExpression( mFilterExpression ); | |||
| } | |||
|
|
|||
| QgsExpressionContext context( QgsExpressionContextUtils::globalProjectLayerScopes( mCoverageLayer.get() ) ); | |||
| req.setExpressionContext( context ); | |||
There was a problem hiding this comment.
This should use the expression context created a couple of lines above
|
Composer is about to be removed (this week). Layout atlas is the new future :) |
In some filters the expression context was not set, so that references to variables would only work in the preview, but not when actually using them.
dgoedkoop
force-pushed
the
filterexprcontext
branch
from
17781fe
to
25bd56c
Compare
|
Ok! I have changed it in both places now, to test with the current composer that it works correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some filters the expression context was not set, so that references to variables would only work in the preview, but not when actually using them. This PR fixes that.
I have attached a sample project with test data: example.zip. The point layer has two cities ("Amsterdam" and "Zaandam") and two villages. A project variable is set to show only cities.
src/core/fieldformatter/qgsvaluerelationfieldformatter.cppsrc/core/composer/qgsatlascomposition.cppThe file
src/core/layout/qgslayoutatlas.cppseems very similar to the latter of the above, so I changed it as well. However, I cannot find any actual usage of it. What is the purpose of it?Checklist
fixes #11111in the commit message next to the description[FEATURE]in the commit message[needs-docs]in the commit message and containt sufficient information in the commit message to be documentedscripts/prepare-commit.shscript before each commit