Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG code for cursors a bit minimized #6483

Closed
wants to merge 2 commits into from

Conversation

FelisPimeja
Copy link
Contributor

List of icons changed:

  • mCapturePoint.svg
  • mCrossHair.svg
  • mIdentify.svg
  • mSampler.svg
  • mSelect.svg
  • mZoomIn.svg
  • mZoomOut.svg

List of icons changed:
mCapturePoint.svg
mCrossHair.svg
mIdentify.svg
mSampler.svg
mSelect.svg
mZoomIn.svg
mZoomOut.svg
@nyalldawson nyalldawson closed this Mar 1, 2018
@nyalldawson nyalldawson reopened this Mar 1, 2018
@rduivenvoorde
Copy link
Contributor

Hi @FelisPimeja, just wondering I'm a curious guy, no offence please: what is the purpose of this?

Is it just to have cleaner svg?
Is it because rendering becomes faster?

I just copied mCapturePoint.svg old and new svg to a file and opened these:

selection_336

Is the removal of the white ring by choice?

Maybe it is good to add screen shots of the icons like this, to make the PR more 'lively' :-)
And it is easier for people to (maybe) see the difference, and to help them to decide to pull or not?

@elpaso
Copy link
Contributor

elpaso commented Mar 10, 2018

Wait, the white ring must not go away: it is essential when hovering on a dark background.

fixed mSampler.svg and mCapturePoint.svg
@FelisPimeja
Copy link
Contributor Author

Hi @FelisPimeja, just wondering I'm a curious guy, no offence please: what is the purpose of this?

Is it just to have cleaner svg?
Is it because rendering becomes faster?

Wait, the white ring must not go away: it is essential when hovering on a dark background.

Sorry friends - that was an error! @rduivenvoorde, @elpaso, thank you for catching it. Double checked and fixed it and also mSampler.svg

@FelisPimeja FelisPimeja reopened this Mar 13, 2018
@nirvn
Copy link
Contributor

nirvn commented May 8, 2018

This has been fixed, closing.

@nirvn nirvn closed this May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants