[FEATURE][needs-docs] add filter line edit to query builder #6704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any objection to merge this? |
|
for me no problem, but seems travis is not happy, btw seems not related with your PR |
nyalldawson
reviewed
Apr 1, 2018
src/gui/qgsquerybuilder.cpp
Outdated
| @@ -73,6 +73,9 @@ QgsQueryBuilder::QgsQueryBuilder( QgsVectorLayer *layer, | |||
| lblDataUri->setText( tr( "Set provider filter on %1" ).arg( layer->name() ) ); | |||
| txtSQL->setText( mOrigSubsetString ); | |||
|
|
|||
| mFilterLineEdit->setPlaceholderText( tr( "Search" ) ); | |||
| connect( mFilterLineEdit, &QgsFilterLineEdit::textChanged, this, &QgsQueryBuilder::onTextChanged ); | |||
There was a problem hiding this comment.
mFilterLineEdit->setShowSearchIcon( true );
(probably needed for the expression query builder too!)
There was a problem hiding this comment.
Are you saying to replace the placeholder string with icon?
There was a problem hiding this comment.
No, I'm saying add it also so it gets the nice search/filter icon too
nyalldawson
approved these changes
Apr 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a filter line edit to filter values in query builder (same as in expression builder widget)
Checklist
fixes #11111in the commit message next to the description[FEATURE]in the commit message[needs-docs]in the commit message and containt sufficient information in the commit message to be documentedscripts/prepare-commit.shscript before each commit