Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Postgres provider] Speed up feature insertion when pkid column is not set (fixes #18976) #7144

Merged
merged 2 commits into from
Jun 2, 2018
Merged

[Postgres provider] Speed up feature insertion when pkid column is not set (fixes #18976) #7144

merged 2 commits into from
Jun 2, 2018

Commits on Jun 1, 2018

  1. [Postgres provider] Speed up feature insertion when pkid column is no… 

    …t set (fixes qgis#18976)

When inserting features whose attribute column corresponding to the pkid
is empty, and tat this pkid column has a default value using a sequence,
then we can remove it from the INSERT statement completely, which save us
from doing a SELECT nextval(...) for each row. On the provided test case
of that ticket, on a debug build, this cuts down the insertion time from 5 minutes
to 1 minute 10s.
    @rouault
    rouault committed Jun 1, 2018
    Configuration menu
    Copy the full SHA
    cc25727 View commit details
    Browse the repository at this point in the history

  2. [cleanup] use for range based loop

    @rouault
    rouault committed Jun 1, 2018
    Configuration menu
    Copy the full SHA
    a9a8fbd View commit details
    Browse the repository at this point in the history