Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove white background from qgis_icon.svg #7309

Merged
merged 1 commit into from Jun 25, 2018

Conversation

Projects
None yet
4 participants
@daniviga
Copy link
Contributor

daniviga commented Jun 25, 2018

Description

Remove the white background from ./images/icons/qgis_icon.svg making it suitable to be used as the app icon. Not sure if this breaks something else [1]. See #7291 (comment) for further explanations.

Preview: https://github.com/daniviga/QGIS/blob/b232c42ef5ca117139428240ef5838e7dd5d553e/images/icons/qgis_icon.svg

[1] BTW it was already transparent in QGIS 2: https://github.com/daniviga/QGIS/blob/e3148219fe6f6561704634d34954d59efd11306f/images/icons/qgis_icon.svg

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit
@nirvn

nirvn approved these changes Jun 25, 2018

@m-kuhn m-kuhn merged commit b3d2619 into qgis:master Jun 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nyalldawson

This comment has been minimized.

Copy link
Contributor

nyalldawson commented Jun 26, 2018

Ouch, how'd we miss this one for so long!?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.