New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mac] display icon in notification #7734

Merged
merged 2 commits into from Aug 28, 2018

Conversation

Projects
None yet
1 participant
@3nids
Member

3nids commented Aug 28, 2018

there is 2 icons in notifications, one from the app itself and one set from the notification
the icon application seems not to be set correctly on mac for now
only the windon icon is set in main.cpp with myApp.setWindowIcon
the icon defined in application plist does not seem to be correctly set
...so in this PR we set the notification icon to be the QGIS one, so it looks nicer

3nids added some commits Aug 28, 2018

[mac] display icon in notification
there is 2 icons in notifications, one from the app itself and one set from the notification
the icon application seems not to be set correctly on mac for now
only the windon icon is set in main.cpp with myApp.setWindowIcon
the icon defined in application plist does not seem to be correctly set
...so in this PR we set the notification icon to be the QGIS one, so it looks nicer

@3nids 3nids merged commit 2810c92 into qgis:master Aug 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@3nids 3nids deleted the 3nids:mac_notif_icon branch Aug 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment