New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend tree in 'Identify Layers' #7752

Merged
merged 7 commits into from Sep 3, 2018

Conversation

Projects
None yet
5 participants
@3nids
Member

3nids commented Aug 30, 2018

image

This PRs replaces the current table in 'Identify Layers' tab in project properties.
It uses a legend tree with a possibility to filter layers.
You can select elements by cell and check/uncheck selection.
This make working in this table a bit more easy.

There is also a new 'searchable' option for layers, so they can be removed from searchable layers.
see #7752

@nyalldawson nyalldawson added the Feature label Aug 30, 2018

@nyalldawson nyalldawson added this to the 3.4 milestone Aug 30, 2018

@nyalldawson

This comment has been minimized.

Contributor

nyalldawson commented Aug 30, 2018

Yeah, can we switch to two separate PRs please?

@3nids 3nids changed the title from Legend tree in 'Identify Layers' + new built-in locator filter to search in all layers to Legend tree in 'Identify Layers' Aug 31, 2018

@3nids

This comment has been minimized.

Member

3nids commented Aug 31, 2018

now separated in 2 PRs, see #7758
description updated

@3nids 3nids added the Feedback label Aug 31, 2018

@nirvn

This comment has been minimized.

Contributor

nirvn commented Aug 31, 2018

@3nids , UI comments:

  • Move the search widget bellow the layer tree, add a placeholder
  • Also move the [ check selected ] [ uncheck selected ] buttons to sit below the layer tree, left justify it (so you'd get something that looks like: [ check ] [ uncheck ] [--- flexibile space ---] [ filter box__ ])
  • Capitalize the check and uncheck buttons
@nirvn

This comment has been minimized.

Contributor

nirvn commented Aug 31, 2018

Oh also, maybe expand the panel title a bit, "layers" doesn't say much in this context and people might confuse it with a panel to add / remove layers. Layer capabilities or something like that could be a better match.

@3nids

This comment has been minimized.

Member

3nids commented Aug 31, 2018

will do the UI changes!
For the title, I tried 'Layers Capabilities' but it's quite long and makes the left bar too large to see the texts. Ideas?

@andreasneumann

This comment has been minimized.

Member

andreasneumann commented Aug 31, 2018

It would be very nice if one could easily filter away non-spatial tables. Some of our projects use a lot of non-spatial tables and those are usually not relevant for identifying features.

Thanks for this work!

@3nids

This comment has been minimized.

Member

3nids commented Aug 31, 2018

@DelazJ

This comment has been minimized.

Contributor

DelazJ commented Aug 31, 2018

It might close https://issues.qgis.org/issues/7145
Sorry if this is a noob question but what do the check and uncheck selection buttons? I mean which column is altered (maybe, a tooltip is welcome?).

3nids added some commits Aug 29, 2018

switch to legend tree for Identify Layers tab in project properties
also add a 'searchable' option for vector layers (they won't be searched in the locator)
@3nids

This comment has been minimized.

Member

3nids commented Aug 31, 2018

screen shot 2018-08-31 at 14 40 31

@3nids

This comment has been minimized.

Member

3nids commented Aug 31, 2018

@andreasneumann works for you?

@3nids

This comment has been minimized.

Member

3nids commented Aug 31, 2018

@DelazJ the idea is to be able to check/uncheck the selected cells. You cannot work here neither column or row wise. Hence the cell selection.
I did not find a better approach.

@nirvn

This comment has been minimized.

Contributor

nirvn commented Aug 31, 2018

Much better. I think it'd look better if you'd switch the buttons + search widget row & checkbox row around.

@nirvn

This comment has been minimized.

Contributor

nirvn commented Aug 31, 2018

Oh and don't forget to capitalize the buttons

improved UX
* checkbox placement
* capitalize text in buttns
* place holder for line edit
* enable/disable buttons depending on selection
@3nids

This comment has been minimized.

Member

3nids commented Sep 2, 2018

here we go
screen shot 2018-09-02 at 21 18 35

@DelazJ

This comment has been minimized.

Contributor

DelazJ commented Sep 2, 2018

I prefer this dialog.
Shouldn't the "identifiable" status be unchecked (and uncheckable?) for geometryless layers?

@nyalldawson

This comment has been minimized.

Contributor

nyalldawson commented Sep 2, 2018

Just wondering how this work relates to the list of "non-removable" layers under "Data sources". It seems to me like that list should also be moved into this tree too, right? At least, I can't see any difference between a setting for a layer being read only vs a setting for a layer being non-removable.

@andreasneumann works for you?

I think what @andreasneumann meant was that it makes no sense to show the "identifyable" checkbox for non-spatial layers.

@nirvn

This comment has been minimized.

Contributor

nirvn commented Sep 3, 2018

Few more thoughts looking at it again: I think the check button should come before the uncheck, feels like a more natural order.

That said, I'm wondering if we could use a single "toggle check for selected" button instead. That might give you enough space to kick the checkbox up and have a single row.

3nids added some commits Sep 3, 2018

@3nids

This comment has been minimized.

Member

3nids commented Sep 3, 2018

alllllllllllllllllllright....

screen shot 2018-09-03 at 09 31 51

I merged the 2 tabs as 'Data Sources'. So it removes a tab :)

(also: toggle button, non-geom are not identifiable, checkbox not shown for non checkable cells)

@nirvn

This comment has been minimized.

Contributor

nirvn commented Sep 3, 2018

@3nids , thanks for being so responsive to comments. This is looking really good now. You've made me comment-less ;-P

@3nids

This comment has been minimized.

Member

3nids commented Sep 3, 2018

finally ;)

@DelazJ

This comment has been minimized.

Contributor

DelazJ commented Sep 3, 2018

If I may, is there a vertical spacer at the bottom of the dialog to avoid the layers frame to expand? If so, it could be nice to remove it so that the frame better fill the dialog (without losing spacing)

@3nids

This comment has been minimized.

Member

3nids commented Sep 3, 2018

there is no spacer...I can't make it go down...If anyone knows?

@3nids

This comment has been minimized.

Member

3nids commented Sep 3, 2018

I will merge as is, it will be easy to fix the UI later on.

@3nids 3nids merged commit 3f85938 into qgis:master Sep 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@3nids 3nids deleted the 3nids:project_layers branch Sep 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment