Show a warning when pasted feature geometry collapsed #8125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... due to due to intersection avoidance Features are still pasted but the user is warned. Fixes qgis#20020
If the geoms where originally invalid, do not show the warning.
m-kuhn
reviewed
Oct 6, 2018
| messageBar()->pushMessage( tr( "Paste features" ), | ||
| tr( "%1 of %2 features could be successfully pasted." ).arg( nCopiedFeatures ).arg( nTotalFeatures ), | ||
| Qgis::Warning, messageTimeout() ); | ||
| message = tr( "%1 of %2 features could be successfully pasted." ).arg( nCopiedFeatures ).arg( nTotalFeatures ); |
There was a problem hiding this comment.
tr( "%1 of %n feature(s) ...", nTotalFeatures ).arg( nCopiedFeatures ) should be supersmart about things. But I never verified ;)
nyalldawson
reviewed
Oct 7, 2018
| QgsExpressionContext context = pasteVectorLayer->createExpressionContext(); | ||
|
|
||
|
|
||
| QgsFeatureList compatibleFeatures( QgsVectorLayerUtils::makeFeaturesCompatible( features, pasteVectorLayer ) ); |
There was a problem hiding this comment.
Are we certain that features here always have their original QgsFields set?
There was a problem hiding this comment.
I would say yes, AFAIK features can only come from a copy operation from a layer source, QgsFields should be there. I did a manual test with copy/paste from layers with different fieldset but sharing a few field names and everything worked just fine if is that what you are worried about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... due to due to intersection avoidance
Features are still pasted but the user is warned.
Fixes #20020