Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SLD 1.0 export for rasters #9049

Merged
merged 24 commits into from Feb 11, 2019
Merged

Add SLD 1.0 export for rasters #9049

merged 24 commits into from Feb 11, 2019

Conversation

luipir
Copy link
Contributor

@luipir luipir commented Jan 31, 2019

Description

The PR add the ability to export QGIS raster style as SLD 1.0 with geoserver flavours

The PR has been sponsored by Geosolution [1]

[1] https://www.geo-solutions.it/

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@luipir luipir changed the title [FEATURE] Add SLD 1.0 export for rasters [FEATURE][needs-docs] Add SLD 1.0 export for rasters Jan 31, 2019
@luipir luipir mentioned this pull request Jan 31, 2019
8 tasks
@luipir
Copy link
Contributor Author

luipir commented Jan 31, 2019

I'll check failing spell check tomorrow... I do not understand why prepare_commit.sh hasn't been applied

src/app/qgsrasterlayerproperties.cpp Outdated Show resolved Hide resolved
src/core/qgsmaplayer.cpp Outdated Show resolved Hide resolved
src/core/raster/qgscontrastenhancement.cpp Outdated Show resolved Hide resolved
src/core/raster/qgscontrastenhancement.h Outdated Show resolved Hide resolved
src/core/raster/qgsmultibandcolorrenderer.cpp Outdated Show resolved Hide resolved
src/core/raster/qgsrasterlayer.cpp Show resolved Hide resolved
src/core/raster/qgsrasterrenderer.cpp Outdated Show resolved Hide resolved
src/core/raster/qgssinglebandgrayrenderer.cpp Show resolved Hide resolved
src/core/raster/qgssinglebandgrayrenderer.cpp Outdated Show resolved Hide resolved
src/core/raster/qgssinglebandpseudocolorrenderer.cpp Outdated Show resolved Hide resolved
@nyalldawson
Copy link
Collaborator

So the desire is to merge in 3.6 and then backport to 3.4?

@luipir
Copy link
Contributor Author

luipir commented Jan 31, 2019

So the desire is to merge in 3.6 and then backport to 3.4?

right, was my error writing the email in dev list

and thanks for the review... I'll work on it

src/core/qgsmaplayer.cpp Outdated Show resolved Hide resolved
src/core/qgsmaplayer.cpp Outdated Show resolved Hide resolved
@m-kuhn m-kuhn added the Feature label Feb 1, 2019
@m-kuhn m-kuhn changed the title [FEATURE][needs-docs] Add SLD 1.0 export for rasters Add SLD 1.0 export for rasters Feb 1, 2019
@luipir
Copy link
Contributor Author

luipir commented Feb 4, 2019

@nyalldawson and @jef-n let me know if you need more to review

src/core/qgsmaplayer.cpp Outdated Show resolved Hide resolved
src/core/raster/qgscontrastenhancement.cpp Outdated Show resolved Hide resolved
@nyalldawson
Copy link
Collaborator

Looks good to me. I can't review the actual SLD logic, but the code looks good.

Co-Authored-By: luipir <luipir@gmail.com>
@luipir
Copy link
Contributor Author

luipir commented Feb 8, 2019

I can't review the actual SLD logic

@nyalldawson I tested against a geoserver 2.14 version. I suggest to leave to @aaime the last word about SLD correctness.

@aaime
Copy link
Contributor

aaime commented Feb 11, 2019

I had a look at the code and tested interactively the various export modes. Looks good to me, +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants