{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":278674713,"defaultBranch":"master","name":"gosqs","ownerLogin":"qhenkart","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2020-07-10T15:52:38.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/5798752?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1684512366.8305678","currentOid":""},"activityList":{"items":[{"before":null,"after":"0303d98675b828cbf14bb0cb3c2cd93ee7984731","ref":"refs/heads/revert-circle","pushedAt":"2023-05-19T16:06:06.830Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"qhenkart","name":"Quest Henkart","path":"/qhenkart","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5798752?s=80&v=4"},"commit":{"message":"re-activate circleci after upstream error","shortMessageHtmlLink":"re-activate circleci after upstream error"}},{"before":"07095ca5c1ee90c0f090b9b7befa2126f091cb67","after":null,"ref":"refs/heads/revert-master-2","pushedAt":"2023-05-19T14:58:35.687Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"qhenkart","name":"Quest Henkart","path":"/qhenkart","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5798752?s=80&v=4"}},{"before":null,"after":"07095ca5c1ee90c0f090b9b7befa2126f091cb67","ref":"refs/heads/master","pushedAt":"2023-05-19T14:58:35.452Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"qhenkart","name":"Quest Henkart","path":"/qhenkart","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5798752?s=80&v=4"},"commit":{"message":"Fix custom logger assignment (#9)\n\n* In `consumer.go` the `NewConsumer` function was testing if the `Logger` attribute\r\n  on the Config struct is `nil` and if it was it assigned the consumer\r\n  logger to `&defaultLogger{}` but if the Config.Logger is not nil its value\r\n  was never getting set on the consumer leaving consumer.logger == nil\r\n\r\n* In the `Logger` method on 109 there is a check for whether\r\n  `consumer.logger == nil` and if it is we return `&defaultLogger{}`\r\n\r\n* Combined these to pieces of logic result in always ignoring a custom\r\n  Logger attribute when it is set on Config.\r\n\r\n* This switches the logic in `NewConsumer` to match the pattern for\r\n  other optional attributes by checking if the `Logger` attribute on\r\n  the provided config is `!= nil` and setting consumer's logger to\r\n  the provided logger\r\n\r\n* If there is no logger assigned on Config `consumer.logger` will\r\n  remain `nil` and the `Logger` function will dutifly return a\r\n  `&defaultLogger{}`","shortMessageHtmlLink":"Fix custom logger assignment (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1586817739\" data-permission-text=\"Title is private\" data-url=\"https://github.com/qhenkart/gosqs/issues/9\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/qhenkart/gosqs/pull/9/hovercard\" href=\"https://github.com/qhenkart/gosqs/pull/9\">#9</a>)"}},{"before":"94fe22e2aca0b513e4aa18acb16136d05f10f034","after":null,"ref":"refs/heads/master","pushedAt":"2023-05-19T14:58:29.296Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"qhenkart","name":"Quest Henkart","path":"/qhenkart","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5798752?s=80&v=4"}},{"before":null,"after":"94fe22e2aca0b513e4aa18acb16136d05f10f034","ref":"refs/heads/old-master","pushedAt":"2023-05-19T14:58:28.704Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"qhenkart","name":"Quest Henkart","path":"/qhenkart","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5798752?s=80&v=4"},"commit":{"message":"revert","shortMessageHtmlLink":"revert"}},{"before":"94fe22e2aca0b513e4aa18acb16136d05f10f034","after":null,"ref":"refs/heads/revert-master","pushedAt":"2023-05-19T14:58:13.127Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"qhenkart","name":"Quest Henkart","path":"/qhenkart","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5798752?s=80&v=4"}},{"before":null,"after":"07095ca5c1ee90c0f090b9b7befa2126f091cb67","ref":"refs/heads/revert-master-2","pushedAt":"2023-05-19T14:57:41.547Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"qhenkart","name":"Quest Henkart","path":"/qhenkart","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5798752?s=80&v=4"},"commit":{"message":"Fix custom logger assignment (#9)\n\n* In `consumer.go` the `NewConsumer` function was testing if the `Logger` attribute\r\n  on the Config struct is `nil` and if it was it assigned the consumer\r\n  logger to `&defaultLogger{}` but if the Config.Logger is not nil its value\r\n  was never getting set on the consumer leaving consumer.logger == nil\r\n\r\n* In the `Logger` method on 109 there is a check for whether\r\n  `consumer.logger == nil` and if it is we return `&defaultLogger{}`\r\n\r\n* Combined these to pieces of logic result in always ignoring a custom\r\n  Logger attribute when it is set on Config.\r\n\r\n* This switches the logic in `NewConsumer` to match the pattern for\r\n  other optional attributes by checking if the `Logger` attribute on\r\n  the provided config is `!= nil` and setting consumer's logger to\r\n  the provided logger\r\n\r\n* If there is no logger assigned on Config `consumer.logger` will\r\n  remain `nil` and the `Logger` function will dutifly return a\r\n  `&defaultLogger{}`","shortMessageHtmlLink":"Fix custom logger assignment (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1586817739\" data-permission-text=\"Title is private\" data-url=\"https://github.com/qhenkart/gosqs/issues/9\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/qhenkart/gosqs/pull/9/hovercard\" href=\"https://github.com/qhenkart/gosqs/pull/9\">#9</a>)"}},{"before":null,"after":"94fe22e2aca0b513e4aa18acb16136d05f10f034","ref":"refs/heads/revert-master","pushedAt":"2023-05-19T14:54:39.147Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"qhenkart","name":"Quest Henkart","path":"/qhenkart","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5798752?s=80&v=4"},"commit":{"message":"revert","shortMessageHtmlLink":"revert"}},{"before":"dfd52a20249f226c887528ddd07e72c6ed0bc5b4","after":"94fe22e2aca0b513e4aa18acb16136d05f10f034","ref":"refs/heads/master","pushedAt":"2023-05-19T08:36:58.395Z","pushType":"push","commitsCount":1,"pusher":{"login":"qhenkart","name":"Quest Henkart","path":"/qhenkart","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5798752?s=80&v=4"},"commit":{"message":"revert","shortMessageHtmlLink":"revert"}},{"before":"5d2b37dc3993ab9c71e0dbb1945604aceaac82cc","after":"dfd52a20249f226c887528ddd07e72c6ed0bc5b4","ref":"refs/heads/master","pushedAt":"2023-05-19T08:30:13.308Z","pushType":"push","commitsCount":1,"pusher":{"login":"qhenkart","name":"Quest Henkart","path":"/qhenkart","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5798752?s=80&v=4"},"commit":{"message":"revert","shortMessageHtmlLink":"revert"}},{"before":"07095ca5c1ee90c0f090b9b7befa2126f091cb67","after":"5d2b37dc3993ab9c71e0dbb1945604aceaac82cc","ref":"refs/heads/master","pushedAt":"2023-05-19T08:25:29.210Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"qhenkart","name":"Quest Henkart","path":"/qhenkart","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5798752?s=80&v=4"},"commit":{"message":"add visibility timeout configuration specific to a queue","shortMessageHtmlLink":"add visibility timeout configuration specific to a queue"}},{"before":"91824b30592c9984986496be1cd628e72c6570a4","after":"07095ca5c1ee90c0f090b9b7befa2126f091cb67","ref":"refs/heads/master","pushedAt":"2023-05-04T05:53:26.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"qhenkart","name":"Quest Henkart","path":"/qhenkart","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5798752?s=80&v=4"},"commit":{"message":"Fix custom logger assignment (#9)\n\n* In `consumer.go` the `NewConsumer` function was testing if the `Logger` attribute\r\n  on the Config struct is `nil` and if it was it assigned the consumer\r\n  logger to `&defaultLogger{}` but if the Config.Logger is not nil its value\r\n  was never getting set on the consumer leaving consumer.logger == nil\r\n\r\n* In the `Logger` method on 109 there is a check for whether\r\n  `consumer.logger == nil` and if it is we return `&defaultLogger{}`\r\n\r\n* Combined these to pieces of logic result in always ignoring a custom\r\n  Logger attribute when it is set on Config.\r\n\r\n* This switches the logic in `NewConsumer` to match the pattern for\r\n  other optional attributes by checking if the `Logger` attribute on\r\n  the provided config is `!= nil` and setting consumer's logger to\r\n  the provided logger\r\n\r\n* If there is no logger assigned on Config `consumer.logger` will\r\n  remain `nil` and the `Logger` function will dutifly return a\r\n  `&defaultLogger{}`","shortMessageHtmlLink":"Fix custom logger assignment (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1586817739\" data-permission-text=\"Title is private\" data-url=\"https://github.com/qhenkart/gosqs/issues/9\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/qhenkart/gosqs/pull/9/hovercard\" href=\"https://github.com/qhenkart/gosqs/pull/9\">#9</a>)"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADMEwfEwA","startCursor":null,"endCursor":null}},"title":"Activity · qhenkart/gosqs"}