Read builtin #1

Merged
merged 6 commits into from Jul 8, 2012

Conversation

Projects
None yet
3 participants

Hi, I'm making this pull request as you suggested. :)

qiaomuf was assigned Jun 6, 2012

@betelgeuse betelgeuse commented on an outdated diff Jul 8, 2012

src/builtins/unset_builtin.cpp
@@ -26,6 +26,10 @@
#include "core/interpreter.h"
+using namespace boost::xpressive;
+
+sregex index_pattern = sregex::compile("^(.*)\\[(\\d*)\\]$");
@betelgeuse

betelgeuse Jul 8, 2012

Collaborator

this creates a global variable. It needs to be either static or inside an anonymous namespace

@qiaomuf qiaomuf added a commit that referenced this pull request Jul 8, 2012

@qiaomuf qiaomuf Merge pull request #1 from Aparicio99/master
Read builtin
f6fa493

@qiaomuf qiaomuf merged commit f6fa493 into qiaomuf:master Jul 8, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment