This repository has been archived by the owner on Sep 23, 2023. It is now read-only.
Fix map markers on qiime and emp #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it works, it works.. I just wish we knew why it stopped working. Do you think we can look into that a little bit before we merge? It just seems weird to me that it would randomly stop working when we have changed nothing in our code... maybe the google maps API changed? |
|
👍 |
|
This is on webdev now |
|
Thanks for deploying this @teravest, just noticed that the markers are showing a "person" whilst these should be the generic Google Maps markers, aside from that, it looks great. |
|
Yep, the icons should be changed 👍 Other than that, I'm happy with it! Thanks, @teravest |
|
Updated on webdev with no men |
ElDeveloper
added a commit
that referenced
this pull request
Mar 7, 2014
Fix map markers on qiime and emp
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The map markers stopped working about a day ago but still worked on american gut.
I replaced the setMarkers function with the version of the function from the americangut page.
Markers are displaying in firefox, Safari, and Chrome now.