ENH: added citations #196
Merged
ENH: added citations #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebolyen
reviewed
Apr 20, 2018
q2_diversity/plugin_setup.py
Outdated
| citations['vazquez2013emperor'], | ||
| citations['jaccard1908nouvelles'], | ||
| citations['pielou1966measurement'], | ||
| citations['sorensen1948method']] |
There was a problem hiding this comment.
I hate to say this after all your work, but the pipelines won't typically need citations on their own, as the actions they call are tracked in provenance (and so are their citations). Pipelines only need references if their doing something like open-reference.
There was a problem hiding this comment.
oh right of course! No problem — the pipelines are the minority, and I just copied/pasted the other citations so it really didn't add work.
redundant with sub-action citations
|
Need to make sure we get a citation for this new action: #194 |
gregcaporaso
approved these changes
Apr 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #193